r42009 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42008‎ | r42009 | r42010 >
Date:01:02, 13 October 2008
Author:danny_b
Status:old
Tags:
Comment:
* method attribut values in lowercase
* swapping <form> and <p> nesting to satisfy XHTML
Modified paths:
  • /trunk/extensions/Collection/Collection.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.body.php
@@ -859,7 +859,7 @@
860860 $html = <<<EOS
861861 <h2><span class="mw-headline">$downloadTitle</span></h2>
862862 <p>$downloadText</p>
863 -<form id="downloadForm" action="$url" method="POST">
 863+<form id="downloadForm" action="$url" method="post">
864864 <input id="downloadTitle" name="downloadTitle" type="hidden"></input>
865865 <input id="downloadSubtitle" name="downloadSubtitle" type="hidden"></input>
866866 EOS
@@ -920,7 +920,7 @@
921921
922922 $url = htmlspecialchars( SkinTemplate::makeSpecialUrlSubpage( 'Collection', 'save_collection/' ) );
923923 $html .= <<<EOS
924 -<form id="saveForm" action="$url" method="POST">
 924+<form id="saveForm" action="$url" method="post">
925925 <input id="personalCollType" type="radio" name="colltype" value="personal" checked="checked"></input>
926926 <label for="personalCollType">$personalColl</label>
927927 <label for="personalCollTitle">$personalTitle</label>
@@ -953,7 +953,7 @@
954954 $escapedTitle = htmlspecialchars( $title->getPrefixedText() );
955955 $url = htmlspecialchars( SkinTemplate::makeSpecialUrlSubpage( 'Collection', 'save_collection/' ) );
956956 $wgOut->addHTML( <<<EOS
957 -<form action="$url" method="POST">
 957+<form action="$url" method="post">
958958 <input name="overwrite" type="submit" value="$yes"></input>
959959 <input name="abort" type="submit" value="$no"></input>
960960 <input name="colltitle" type="hidden" value="$escapedTitle"></input>
@@ -974,7 +974,7 @@
975975 $escapedTitle = htmlspecialchars( $title->getPrefixedText() );
976976 $url = htmlspecialchars( SkinTemplate::makeSpecialUrlSubpage( 'Collection', 'load_collection/' ) );
977977 $wgOut->addHTML( <<<EOS
978 -<form action="$url" method="POST">
 978+<form action="$url" method="post">
979979 <input name="overwrite" type="submit" value="$overwrite"></input>
980980 <input name="append" type="submit" value="$append"></input>
981981 <input name="cancel" type="submit" value="$cancel"></input>
@@ -1017,13 +1017,13 @@
10181018 $orderLabel = wfMsgHtml( 'coll-order_from_pp', $partnerName );
10191019 $aboutLabel = wfMsgHtml( 'coll-about_pp', $partnerName );
10201020 $html .= <<<EOS
 1021+<form action="$formurl" method="get">
10211022 <p>
1022 - <form action="$formurl" method="GET">
10231023 <input type="hidden" name="partner" value="$encPartner"/>
10241024 <input type="submit" value="$orderLabel"/>
10251025 <a href="$url" target="_blank">$aboutLabel&nbsp;<img src="$logoURL" alt="$partnerName"/></a>
 1026+</p>
10261027 </form>
1027 -</p>
10281028 EOS
10291029 ;
10301030 }
@@ -1363,3 +1363,4 @@
13641364 return true;
13651365 }
13661366 }
 1367+
\ No newline at end of file

Follow-up revisions

RevisionCommit summaryAuthorDate
r42016remove funky char from the end of the file introduced in r42009brion04:55, 13 October 2008

Status & tagging log