r41914 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41913‎ | r41914 | r41915 >
Date:01:10, 10 October 2008
Author:brion
Status:old
Tags:
Comment:
snip some commented-out debug code no longer needed
Modified paths:
  • /trunk/extensions/CodeReview/CodeRevisionView.php (modified) (history)
  • /trunk/extensions/CodeReview/codereview.js (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/codereview.js
@@ -35,7 +35,6 @@
3636 CodeReview.showDiff(data.code.rev.diff);
3737 } else {
3838 CodeReview.showDiff('Diff load failed. :(');
39 - //alert(dumpWtf(data));
4039 }
4140 };
4241 CodeReview.diffTarget = function() {
@@ -44,19 +43,3 @@
4544 CodeReview.showDiff = function(diffHtml) {
4645 CodeReview.diffTarget().innerHTML = diffHtml;
4746 };
48 -
49 -
50 -function dumpWtf(obj) {
51 - var out = typeof(obj) + ' ';
52 - if (typeof(obj) == 'object' || typeof(obj) == 'array' ) {
53 - out += '(';
54 - for (var i in obj) {
55 - out += i + ': ' +
56 - dumpWtf(obj[i]) + "\n";
57 - }
58 - out += ')';
59 - } else {
60 - out += obj;
61 - }
62 - return out;
63 -}
Index: trunk/extensions/CodeReview/CodeRevisionView.php
@@ -249,19 +249,6 @@
250250 }
251251 );" );
252252 return "Loading diff...";
253 - /*
254 - return
255 - Xml::openElement( 'script',
256 - array(
257 - 'src' => $wgServer . $wgScriptPath . '/api.php?' .
258 - wfArrayToCgi( array(
259 - 'action' => 'codediff',
260 - 'repo' => $this->mRepo->getName(),
261 - 'rev' => $this->mRev->getId(),
262 - 'format' => 'json',
263 - 'callback' => 'alert' ) ) ) ) .
264 - "</script>";
265 - */
266253 }
267254
268255 function formatComments() {

Status & tagging log