r41915 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41914‎ | r41915 | r41916 >
Date:01:12, 10 October 2008
Author:aaron
Status:old
Tags:
Comment:
Rename $skipCache
Modified paths:
  • /trunk/extensions/CodeReview/CodeRepository.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeRepository.php
@@ -149,10 +149,10 @@
150150
151151 /**
152152 * @param int $rev Revision ID
153 - * @param $skipCache 'skipcache' to avoid caching
 153+ * @param $useCache 'skipcache' to avoid caching
154154 * 'cached' to *only* fetch if cached
155155 */
156 - function getDiff( $rev, $skipCache = '' ) {
 156+ function getDiff( $rev, $useCache = '' ) {
157157 global $wgMemc;
158158
159159 $rev1 = $rev - 1;
@@ -164,13 +164,13 @@
165165 }
166166
167167 $key = wfMemcKey( 'svn', md5( $this->mPath ), 'diff', $rev1, $rev2 );
168 - if( $skipCache === 'skipcache' ) {
 168+ if( $useCache === 'skipcache' ) {
169169 $data = NULL;
170170 } else {
171171 $data = $wgMemc->get( $key );
172172 }
173173
174 - if( !$data && $skipCache != 'cached' ) {
 174+ if( !$data && $useCache != 'cached' ) {
175175 $svn = SubversionAdaptor::newFromRepo( $this->mPath );
176176 $data = $svn->getDiff( '', $rev1, $rev2 );
177177 $wgMemc->set( $key, $data, 3600*24*3 );

Status & tagging log