r41726 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r41725‎ | r41726 | r41727 >
Date:04:36, 6 October 2008
Author:mrzman
Status:old (Comments)
Tags:todo 
Comment:
Pass the actual text from $row->title (escaped with htmlspecialchars) instead of null so we can see what the bad title actually is.
Modified paths:
  • /trunk/phase3/includes/PageQueryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/PageQueryPage.php
——@@ -17,9 +17,9 @@
1818 public function formatResult( $skin, $row ) {
1919 global $wgContLang;
2020 $title = Title::makeTitleSafe( $row->namespace, $row->title );
21 - $text = null;
 21+ $text = $row->title;
2222 if ($title instanceof Title)
23 - $text = htmlspecialchars( $wgContLang->convert( $title->getPrefixedText() ) );
24 - return $skin->link( $title, $text, array(), array(), array('known', 'noclasses') );
 23+ $text = $wgContLang->convert( $title->getPrefixedText() );
 24+ return $skin->link( $title, htmlspecialchars($text), array(), array(), array('known', 'noclasses') );
2525 }
2626 }

Comments

#Comment by Brion VIBBER (talk | contribs)   01:08, 24 October 2008

Uhhhhrmf? Ok sorta weird... will be missing the namespace though. Tagging todo for a future improvement but not a blocker.

Status & tagging log