r41402 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41401‎ | r41402 | r41403 >
Date:23:02, 29 September 2008
Author:brion
Status:old
Tags:
Comment:
Reverted r41301, r41332 -- weird overly-specific URL tweak setting for bug 15739.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -714,7 +714,7 @@
715715 */
716716 public function getLocalURL( $query = '', $variant = false ) {
717717 global $wgArticlePath, $wgScript, $wgServer, $wgRequest;
718 - global $wgVariantArticlePath, $wgContLang, $wgUser, $wgArticlePathForCurid;
 718+ global $wgVariantArticlePath, $wgContLang, $wgUser;
719719
720720 if( is_array( $query ) ) {
721721 $query = wfArrayToCGI( $query );
@@ -738,7 +738,7 @@
739739 }
740740 } else {
741741 $dbkey = wfUrlencode( $this->getPrefixedDBkey() );
742 - if ( $query == '' || ($wgArticlePathForCurid && substr_count( $query, '&' ) == 0 && strpos( $query, 'curid=' ) === 0 ) ) {
 742+ if ( $query == '' ) {
743743 if( $variant != false && $wgContLang->hasVariants() ) {
744744 if( $wgVariantArticlePath == false ) {
745745 $variantArticlePath = "$wgScript?title=$1&variant=$2"; // default
@@ -750,7 +750,6 @@
751751 } else {
752752 $url = str_replace( '$1', $dbkey, $wgArticlePath );
753753 }
754 - $url = wfAppendQuery( $url, $query );
755754 } else {
756755 global $wgActionPaths;
757756 $url = false;
Index: trunk/phase3/includes/DefaultSettings.php
@@ -3455,10 +3455,3 @@
34563456 * Requires memcached.
34573457 */
34583458 $wgPasswordAttemptThrottle = array( 'count' => 5, 'seconds' => 300 );
3459 -
3460 -/**
3461 - * Allow using articlepath for links where the only querystring is a curid (e.g. use /wiki/Main_Page?curid=1)
3462 - * WARNING: This will not work for all hosts or configuration setup, so BE CAREFUL.
3463 - * Only use this setting if you have to, as it is not recommended.
3464 - */
3465 -$wgArticlePathForCurid = false;
Index: trunk/phase3/RELEASE-NOTES
@@ -140,8 +140,6 @@
141141 restriction types on the protection form.
142142 * (bug 8440) Allow preventing blocked users from editing their talk pages
143143 * Improved upload file type detection for OpenDocument formats
144 -* (bug 15739) Add $wgArticlePathForCurid to make links with only curid=# as the
145 - query string use the article path, rather than the script path
146144 * Added the ability to set the target attribute on external links with
147145 $wgExternalLinkTarget
148146 * (bug 674) Allow admins to block users from editing specific articles and

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r41301(bug 15739) Add $wgArticlePathForCurid to make links with only curid=# as the...mattj09:49, 27 September 2008
r41332Don't duplicate code, use wfAppendQuerysimetrical01:48, 28 September 2008

Status & tagging log