r41332 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41331‎ | r41332 | r41333 >
Date:01:48, 28 September 2008
Author:simetrical
Status:old (Comments)
Tags:
Comment:
Don't duplicate code, use wfAppendQuery
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -845,13 +845,7 @@
846846 } else {
847847 $url = str_replace( '$1', $dbkey, $wgArticlePath );
848848 }
849 - if( $query ){
850 - if( strpos( $url, '&' ) ){
851 - $url .= '&' . $query;
852 - }else{
853 - $url .= '?' . $query;
854 - }
855 - }
 849+ $url = wfAppendQuery( $url, $query );
856850 } else {
857851 global $wgActionPaths;
858852 $url = false;

Follow-up revisions

RevisionCommit summaryAuthorDate
r41402Reverted r41301, r41332 -- weird overly-specific URL tweak setting for bug 15...brion23:02, 29 September 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   01:09, 1 October 2008

Followup to r41301; reverted in r41402

Status & tagging log