r41401 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41400‎ | r41401 | r41402 >
Date:21:53, 29 September 2008
Author:aaron
Status:old
Tags:
Comment:
Form appearance tweaks
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticle.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/flaggedrevs.css (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/flaggedrevs.css
@@ -276,7 +276,8 @@
277277 clear: both;
278278 }
279279
280 -.fr-rating-controls * {
 280+.fr-rating-controls,
 281+.fr-rating-controls-disabled {
281282 vertical-align: middle;
282283 line-height: 1em;
283284 }
Index: trunk/extensions/FlaggedRevs/FlaggedArticle.php
@@ -1371,7 +1371,8 @@
13721372 'id' => 'fr-rating-controls-disabled') );
13731373 $toggle = array( 'disabled' => "disabled" );
13741374 } else {
1375 - $form .= Xml::openElement( 'div', array('class' => 'fr-rating-controls', 'id' => 'fr-rating-controls') );
 1375+ $form .= Xml::openElement( 'div', array('class' => 'fr-rating-controls',
 1376+ 'id' => 'fr-rating-controls') );
13761377 $toggle = array();
13771378 }
13781379 $size = count(FlaggedRevs::getDimensions(),1) - count(FlaggedRevs::getDimensions());
@@ -1394,7 +1395,7 @@
13951396 }
13961397 $quantity = count( $label );
13971398 $form .= Xml::openElement( 'span', array('class' => 'fr-rating-options') ) . "\n";
1398 - $form .= "<b>" . FlaggedRevs::getTagMsg($quality) . ":</b>&nbsp;";
 1399+ $form .= "<b>" . FlaggedRevs::getTagMsg($quality) . ":</b>\n";
13991400 # If the sum of qualities of all flags is above 6, use drop down boxes
14001401 # 6 is an arbitrary value choosen according to screen space and usability
14011402 if( $size > 6 ) {
@@ -1486,7 +1487,7 @@
14871488 'wpReason', 50, '', array('class' => 'fr-comment-box') ) . "&nbsp;&nbsp;&nbsp;</span>";
14881489 }
14891490 $form .= Xml::submitButton( wfMsg('revreview-submit'), array('id' => 'submitreview',
1490 - 'accesskey' => wfMsg('revreview-ak-review'), 'style' => 'margin: .5em 0em 0em 0em;',
 1491+ 'accesskey' => wfMsg('revreview-ak-review'),
14911492 'title' => wfMsg('revreview-tt-review').' ['.wfMsg('revreview-ak-review').']') + $toggle
14921493 );
14931494 $form .= Xml::closeElement( 'span' );

Status & tagging log