r40950 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40949‎ | r40950 | r40951 >
Date:09:13, 17 September 2008
Author:aaron
Status:old
Tags:
Comment:
Add handy diff links
Modified paths:
  • /trunk/extensions/CodeReview/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeRevisionView.php
@@ -108,14 +108,16 @@
109109 $viewvc = $this->mRepo->getViewVcBase();
110110 if( $viewvc ) {
111111 $rev = $this->mRev->getId();
 112+ $prev = $rev - 1;
112113 $safePath = wfUrlEncode( $path );
113 - $link = $this->mSkin->makeExternalLink(
114 - "$viewvc$safePath?view=markup&pathrev=$rev",
115 - $encPath );
 114+ $link = $this->mSkin->makeExternalLink( "$viewvc$safePath?view=markup&pathrev=$rev", $encPath );
 115+ $diff = $this->mSkin->makeExternalLink( "$viewvc$safePath?&pathrev=$rev&r1=$prev&r2=$rev",
 116+ wfMsgHtml('code-rev-diff') );
116117 } else {
117118 $link = $encPath;
 119+ $diff = wfMsgHtml('code-rev-diff');
118120 }
119 - return "<li>$link ($desc)</li>\n";
 121+ return "<li>$link ($desc) ($diff)</li>\n";
120122 }
121123
122124 function formatTags() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r40996Cleanup r40950 in CodeReview:...brion17:07, 18 September 2008

Status & tagging log