| Index: branches/REL1_13/phase3/includes/User.php |
| — | — | @@ -1859,7 +1859,11 @@ |
| 1860 | 1860 | // In the spirit of DWIM |
| 1861 | 1861 | return true; |
| 1862 | 1862 | |
| 1863 | | - return in_array( $action, $this->getRights() ); |
| | 1863 | + // PHP is stupid. |
| | 1864 | + // > $f = array( 'foo', 'bar', 'baz', 0, 'anne' ); |
| | 1865 | + // > print in_array( 'blah', $f ); |
| | 1866 | + // 1 |
| | 1867 | + return in_array( $action, $this->getRights(), true ); |
| 1864 | 1868 | } |
| 1865 | 1869 | |
| 1866 | 1870 | /** |
| Index: branches/REL1_13/phase3/RELEASE-NOTES |
| — | — | @@ -3,6 +3,10 @@ |
| 4 | 4 | Security reminder: MediaWiki does not require PHP's register_globals |
| 5 | 5 | setting since version 1.2.0. If you have it on, turn it *off* if you can. |
| 6 | 6 | |
| | 7 | +== MediaWiki 1.13.2 == |
| | 8 | +* Security: Work around misconfiguration by requiring strict comparisons for |
| | 9 | + in_array in User::isAllowed(). |
| | 10 | + |
| 7 | 11 | == MediaWiki 1.13.1 == |
| 8 | 12 | |
| 9 | 13 | September 6, 2008 |