r40942 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40941‎ | r40942 | r40943 >
Date:00:43, 17 September 2008
Author:demon
Status:old
Tags:
Comment:
(bug 15621) Remove hardcoded English.
Modified paths:
  • /trunk/extensions/LiquidThreads/Lqt.i18n.php (modified) (history)
  • /trunk/extensions/LiquidThreads/LqtPages.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/Lqt.i18n.php
@@ -94,6 +94,7 @@
9595 'lqt_delete_return' => 'Return to $1.',
9696 'lqt_delete_return_link' => 'the talkpage', // subst above
9797 'lqt_delete_unallowed' => 'You are not allowed to delete threads.',
 98+ 'lqt_delete_show' => 'Show deleted threads.',
9899 'lqt_talkpage_autocreate_summary' => 'Talkpage autocreated when first thread was posted.',
99100 'lqt_header_warning_before_big' => '',
100101 'lqt_header_warning_big' => 'You are editing a $1.',
Index: trunk/extensions/LiquidThreads/LqtPages.php
@@ -152,12 +152,10 @@
153153 }
154154 if ( in_array('deletedhistory', $this->user->getRights()) ) {
155155 $show_deleted_checked = $this->request->getBool('lqt_show_deleted_threads') ? 'checked ' : '';
156 - $show_deleted = <<<HTML
157 -<br />
158 -<label for="lqt_show_deleted_threads_checkbox">
159 -<input id="lqt_show_deleted_threads_checkbox" name="lqt_show_deleted_threads" type="checkbox" value="1" $show_deleted_checked />
160 -Show deleted threads</label>
161 -HTML;
 156+ $show_deleted = "<br />\n" .
 157+ "<label for=\"lqt_show_deleted_threads_checkbox\">\n" .
 158+ "<input id=\"lqt_show_deleted_threads_checkbox\" name=\"lqt_show_deleted_threads\" type=\"checkbox\" value=\"1\" $show_deleted_checked />\n" .
 159+ wfMsg( 'lqt_show_deleted' ) . "</label>\n";
162160 } else {
163161 $show_deleted = "";
164162 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r41083Fix regression from r40942, message was mis-i18ned. Test your fucking patches.david00:26, 21 September 2008

Status & tagging log