r41083 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41082‎ | r41083 | r41084 >
Date:00:26, 21 September 2008
Author:david
Status:old
Tags:
Comment:
Fix regression from r40942, message was mis-i18ned. Test your fucking patches.
Modified paths:
  • /trunk/extensions/LiquidThreads/Lqt.i18n.php (modified) (history)
  • /trunk/extensions/LiquidThreads/LqtModel.php (modified) (history)
  • /trunk/extensions/LiquidThreads/LqtPages.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/Lqt.i18n.php
@@ -94,7 +94,7 @@
9595 'lqt_delete_return' => 'Return to $1.',
9696 'lqt_delete_return_link' => 'the talkpage', // subst above
9797 'lqt_delete_unallowed' => 'You are not allowed to delete threads.',
98 - 'lqt_delete_show' => 'Show deleted threads',
 98+ 'lqt_delete_show_checkbox' => 'Show deleted threads',
9999 'lqt_talkpage_autocreate_summary' => 'Talkpage autocreated when first thread was posted.',
100100 'lqt_header_warning_before_big' => '',
101101 'lqt_header_warning_big' => 'You are editing a $1.',
Index: trunk/extensions/LiquidThreads/LqtPages.php
@@ -155,7 +155,7 @@
156156 $show_deleted = "<br />\n" .
157157 "<label for=\"lqt_show_deleted_threads_checkbox\">\n" .
158158 "<input id=\"lqt_show_deleted_threads_checkbox\" name=\"lqt_show_deleted_threads\" type=\"checkbox\" value=\"1\" $show_deleted_checked />\n" .
159 - wfMsg( 'lqt_show_deleted' ) . "</label>\n";
 159+ wfMsg( 'lqt_delete_show_checkbox' ) . "</label>\n";
160160 } else {
161161 $show_deleted = "";
162162 }
Index: trunk/extensions/LiquidThreads/LqtModel.php
@@ -1145,11 +1145,9 @@
11461146
11471147 if( $t->article()->getTitle()->getNamespace() == NS_USER ) {
11481148 $name = $t->article()->getTitle()->getDBkey();
1149 - // handle talk subpage case
1150 - list($name) = split('/', $name);
 1149+ list($name) = split('/', $name); // subpages
11511150 $user = User::newFromName($name);
1152 - if( $user
1153 - && $user->getID() != $wgUser->getID() ) {
 1151+ if( $user && $user->getID() != $wgUser->getID() ) {
11541152 $user->setNewtalk(true);
11551153 }
11561154 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r40942(bug 15621) Remove hardcoded English.demon00:43, 17 September 2008