r40798 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40797‎ | r40798 | r40799 >
Date:20:41, 13 September 2008
Author:aaron
Status:old
Tags:
Comment:
Revert r40792. Filesort is gone, but table scan is still there for time range.
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryDeletedrevs.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryDeletedrevs.php
@@ -107,12 +107,9 @@
108108 $lb = new LinkBatch($titles);
109109 $where = $lb->constructSet('ar', $db);
110110 $this->addWhere($where);
 111+ } else {
 112+ $this->dieUsage('You have to specify a page title or titles');
111113 }
112 - else
113 - {
114 - $dir = ($params['dir'] == 'older' ? 'DESC' : '');
115 - $this->addOption('ORDER BY', "ar_namespace $dir, ar_title $dir");
116 - }
117114
118115 $this->addOption('LIMIT', $limit + 1);
119116 $this->addWhereRange('ar_timestamp', $params['dir'], $params['start'], $params['end']);

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r40792Reverting r40790 and fixing the filesort properly (by adding an extra ORDER B...catrope18:10, 13 September 2008