r40790 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40789‎ | r40790 | r40791 >
Date:17:56, 13 September 2008
Author:aaron
Status:old
Tags:
Comment:
I swear this table scan filesort was disabled before. Disabling again...thanks to Vyznev for pointing this out.
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryDeletedrevs.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryDeletedrevs.php
@@ -107,6 +107,8 @@
108108 $lb = new LinkBatch($titles);
109109 $where = $lb->constructSet('ar', $db);
110110 $this->addWhere($where);
 111+ } else {
 112+ $this->dieUsage('You have to specify a page title or titles');
111113 }
112114
113115 $this->addOption('LIMIT', $limit + 1);

Follow-up revisions

RevisionCommit summaryAuthorDate
r40792Reverting r40790 and fixing the filesort properly (by adding an extra ORDER B...catrope18:10, 13 September 2008