r40719 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40718‎ | r40719 | r40720 >
Date:00:07, 11 September 2008
Author:demon
Status:old
Tags:
Comment:
(bug 15544) non-index.php entry points prior to setup produced a bad /config/index.php url. Weird edge case, patch by Matt Johnston. Fix out-of-place entry in CREDITS too.
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/templates/NoLocalSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/CREDITS
@@ -42,12 +42,13 @@
4343 * Daniel Arnold
4444 * Danny B.
4545 * Jeremy Baron
 46+* Juliano F. Ravasi
4647 * Louperivois
 48+* Matt Johnston
4749 * Max Semenik
4850 * Michael De La Rue
4951 * Mike Horvath
5052 * Mormegil
51 -* Juliano F. Ravasi
5253 * RememberTheDot
5354 * ST47
5455
Index: trunk/phase3/includes/templates/NoLocalSettings.php
@@ -17,6 +17,10 @@
1818 if( isset( $_SERVER['SCRIPT_NAME'] )) {
1919 $path = htmlspecialchars( preg_replace('/index.php5?/', '', $_SERVER['SCRIPT_NAME']) );
2020 }
 21+#Remove filename in path, prevents going to corrupt URLs (e.g. http://server/path/api.phpconfig/index.php)
 22+if(substr($path, strlen($path)-1) != "/"){
 23+ $path = substr($path, 0, strrpos($path, "/")+1);
 24+}
2125 ?>
2226 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
2327 <html xmlns='http://www.w3.org/1999/xhtml' xml:lang='en' lang='en'>
Index: trunk/phase3/RELEASE-NOTES
@@ -189,6 +189,8 @@
190190 * (bug 14398) mwsuggest.js: Let width of container be configurable
191191 * (bug 15543) Only include user touched timestamp to generated CSS
192192 * (bug 15497) Removed encoding attribute from <?xml ?> tag
 193+* (bug 15544) Wiki not set up message (NoLocalSettings.php) now works for
 194+ non-index.php entry pages (e.g. api.php). Patch by Matt Johnston.
193195
194196
195197 === API changes in 1.14 ===

Follow-up revisions

RevisionCommit summaryAuthorDate
r41047Reverted r40719, plainly flawed, for instance the hard-coded references to in...tstarling02:55, 20 September 2008
r43106(bug 15544) Non-index entry points cause the "Wiki not set up" message to hav...siebrand00:33, 3 November 2008

Status & tagging log