r41047 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41046‎ | r41047 | r41048 >
Date:02:55, 20 September 2008
Author:tstarling
Status:old
Tags:
Comment:
Reverted r40719, plainly flawed, for instance the hard-coded references to index.php have no place if the point is to make it work for other entry points.
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/templates/NoLocalSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/CREDITS
@@ -47,7 +47,6 @@
4848 * Juliano F. Ravasi
4949 * Louperivois
5050 * Marooned
51 -* Matt Johnston
5251 * Max Semenik
5352 * Michael De La Rue
5453 * Mike Horvath
Index: trunk/phase3/includes/templates/NoLocalSettings.php
@@ -17,10 +17,6 @@
1818 if( isset( $_SERVER['SCRIPT_NAME'] )) {
1919 $path = htmlspecialchars( preg_replace('/index.php5?/', '', $_SERVER['SCRIPT_NAME']) );
2020 }
21 -#Remove filename in path, prevents going to corrupt URLs (e.g. http://server/path/api.phpconfig/index.php)
22 -if(substr($path, strlen($path)-1) != "/"){
23 - $path = substr($path, 0, strrpos($path, "/")+1);
24 -}
2521 ?>
2622 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
2723 <html xmlns='http://www.w3.org/1999/xhtml' xml:lang='en' lang='en'>
Index: trunk/phase3/RELEASE-NOTES
@@ -199,8 +199,6 @@
200200 * (bug 14398) mwsuggest.js: Let width of container be configurable
201201 * (bug 15543) Only include user touched timestamp to generated CSS
202202 * (bug 15497) Removed encoding attribute from <?xml ?> tag
203 -* (bug 15544) Wiki not set up message (NoLocalSettings.php) now works for
204 - non-index.php entry pages (e.g. api.php). Patch by Matt Johnston.
205203 * (bug 12284) Special:Preferences now sets a returnto parameter on the link to
206204 Special:Userlogin. Patch by Marooned.
207205 * Fixed the HTTP accept language string detection length in

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r40719(bug 15544) non-index.php entry points prior to setup produced a bad /config/...demon00:07, 11 September 2008