r40677 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40676‎ | r40677 | r40678 >
Date:20:14, 9 September 2008
Author:mrzman
Status:old
Tags:
Comment:
modify r40671, use Sanitizer::escapeHtmlAllowEntities instead to allow & and the like.
Modified paths:
  • /trunk/extensions/ImageMap/ImageMap_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ImageMap/ImageMap_body.php
@@ -70,7 +70,7 @@
7171 if ( wfIsBadImage( $imageTitle->getDBkey() , $parser->mTitle ) ) {
7272 return self::error( 'imagemap_bad_image' );
7373 }
74 - $imageHTML = $parser->makeImage( $imageTitle, htmlspecialchars($options) );
 74+ $imageHTML = $parser->makeImage( $imageTitle, Sanitizer::escapeHtmlAllowEntities($options) );
7575 $parser->mOutput->addImage( $imageTitle->getDBkey() );
7676
7777 $domDoc = new DOMDocument();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r40671(bug 15289) '&' and '<' in captions no longer cause ImageMap to fail, convert...mrzman19:39, 9 September 2008