r40676 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40675‎ | r40676 | r40677 >
Date:20:02, 9 September 2008
Author:dale
Status:old
Tags:
Comment:
fixed null playlist check
Modified paths:
  • /trunk/extensions/MetavidWiki/skins/mv_embed/embedLibs/mv_nativeEmbed.js (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_embed/mv_embed.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MetavidWiki/skins/mv_embed/embedLibs/mv_nativeEmbed.js
@@ -64,8 +64,10 @@
6565 this.start_offset=this.media_element.selected_source.start_offset;
6666
6767 //don't update status if we are not the current clip
68 - if(this.pc.pp.cur_clip.id != this.pc.id)
69 - return true;
 68+ if(this.pc){
 69+ if(this.pc.pp.cur_clip.id != this.pc.id)
 70+ return true;
 71+ }
7072
7173 //only update the interface if controls have been included:
7274 if( this.currentTime > 0 ){
Index: trunk/extensions/MetavidWiki/skins/mv_embed/mv_embed.js
@@ -2804,14 +2804,14 @@
28052805 /*
28062806 * IE and non-firebug debug:
28072807 */
2808 - var log_elm = document.getElementById('mv_js_log');
 2808+ /*var log_elm = document.getElementById('mv_js_log');
28092809 if(!log_elm){
28102810 document.write('<div style="position:absolute;z-index:500;top:0px;left:0px;right:0px;height:150px;"><textarea id="mv_js_log" cols="80" rows="6"></textarea></div>');
28112811 var log_elm = document.getElementById('mv_js_log');
28122812 }
28132813 if(log_elm){
28142814 log_elm.value+=string+"\n";
2815 - }
 2815+ }*/
28162816 }
28172817 //in case of "throw error" type usage
28182818 return false;