r40671 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40670‎ | r40671 | r40672 >
Date:19:39, 9 September 2008
Author:mrzman
Status:old
Tags:
Comment:
(bug 15289) '&' and '<' in captions no longer cause ImageMap to fail, converted with htmlspecialchars.
Modified paths:
  • /trunk/extensions/ImageMap/ImageMap_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ImageMap/ImageMap_body.php
@@ -70,7 +70,7 @@
7171 if ( wfIsBadImage( $imageTitle->getDBkey() , $parser->mTitle ) ) {
7272 return self::error( 'imagemap_bad_image' );
7373 }
74 - $imageHTML = $parser->makeImage( $imageTitle, $options );
 74+ $imageHTML = $parser->makeImage( $imageTitle, htmlspecialchars($options) );
7575 $parser->mOutput->addImage( $imageTitle->getDBkey() );
7676
7777 $domDoc = new DOMDocument();

Follow-up revisions

RevisionCommit summaryAuthorDate
r40677modify r40671, use Sanitizer::escapeHtmlAllowEntities instead to allow &amp; ...mrzman20:14, 9 September 2008