r39241 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39240‎ | r39241 | r39242 >
Date:20:28, 12 August 2008
Author:minuteelectron
Status:old
Tags:
Comment:
* Revert r39133 - bogus fix that does not work.
* Alter message "lqt_youhavenewmessages" so that it does not contain a text parameter.
Modified paths:
  • /trunk/extensions/LiquidThreads/Lqt.i18n.php (modified) (history)
  • /trunk/extensions/LiquidThreads/LqtBaseView.php (modified) (history)
  • /trunk/extensions/LiquidThreads/LqtPages.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/Lqt.i18n.php
@@ -52,7 +52,7 @@
5353 'lqt_change_new_thread' => 'This is the thread\'s initial revision.',
5454 'lqt_change_reply_created' => 'The highlighted comment was created in this revision.',
5555 'lqt_change_edited_root' => 'The highlighted comment was edited in this revision.',
56 - 'lqt_youhavenewmessages' => 'You have $1.',
 56+ 'lqt_youhavenewmessages' => 'You have [$1 new messages].',
5757 'lqt_changes_from' => ' from ',
5858 'lqt_changes_summary_of' => ' of ',
5959 'lqt_protectedfromreply' => 'This thread has been $1 from being replied to.',
Index: trunk/extensions/LiquidThreads/LqtPages.php
@@ -214,7 +214,7 @@
215215 }
216216
217217 global $wgRequest;
218 - if( $this->methodApplies('talkpage_new_thread') || $wgRequest->getBool( 'redlink' ) ) {
 218+ if( $this->methodApplies('talkpage_new_thread') ) {
219219 $this->showNewThreadForm();
220220 } else {
221221
Index: trunk/extensions/LiquidThreads/LqtBaseView.php
@@ -82,9 +82,7 @@
8383 $action = $request->getVal('action');
8484 $header_actions = array('history', 'edit', 'submit');
8585 global $wgRequest;
86 - if( $wgRequest->getBool( 'redlink' ) ) {
87 - $viewname = self::$views['TalkpageView'];
88 - } else if ($request->getVal('lqt_method', null) === null &&
 86+ if ($request->getVal('lqt_method', null) === null &&
8987 ( in_array( $action, $header_actions ) ||
9088 $request->getVal('diff', null) !== null ) ) {
9189 $viewname = self::$views['TalkpageHeaderView'];
@@ -247,7 +245,7 @@
248246 &&! $watchlist_t->equals($wgTitle)
249247 &&! $usertalk_t->equals($wgTitle)
250248 ) {
251 - $s = wfMsg('lqt_youhavenewmessages', '<a href="'.$newmsg_t->getFullURL().'">'.wfMsg('newmessageslink').'</a>');
 249+ $s = wfMsgExt('lqt_youhavenewmessages', array( 'parseinline' ), $newmsg_t->getFullURL());
252250 $tpl->set("newtalk", $s);
253251 $wgOut->setSquidMaxage(0);
254252 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r39133* (bug 15092) Make links to non-existant talk pages from history (and other a...minuteelectron12:10, 11 August 2008

Status & tagging log