r39133 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39132‎ | r39133 | r39134 >
Date:12:10, 11 August 2008
Author:minuteelectron
Status:old
Tags:
Comment:
* (bug 15092) Make links to non-existant talk pages from history (and other action) pages prompt the user to add a new section rather than edit the header.
Modified paths:
  • /trunk/extensions/LiquidThreads/LqtBaseView.php (modified) (history)
  • /trunk/extensions/LiquidThreads/LqtPages.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/LqtPages.php
@@ -213,7 +213,8 @@
214214 $remember_sort_checked = '';
215215 }
216216
217 - if( $this->methodApplies('talkpage_new_thread') ) {
 217+ global $wgRequest;
 218+ if( $this->methodApplies('talkpage_new_thread') || $wgRequest->getBool( 'redlink' ) ) {
218219 $this->showNewThreadForm();
219220 } else {
220221
Index: trunk/extensions/LiquidThreads/LqtBaseView.php
@@ -81,7 +81,10 @@
8282 actions come up, to avoid hacking the various history, editing, etc. code. */
8383 $action = $request->getVal('action');
8484 $header_actions = array('history', 'edit', 'submit');
85 - if ($request->getVal('lqt_method', null) === null &&
 85+ global $wgRequest;
 86+ if( $wgRequest->getBool( 'redlink' ) ) {
 87+ $viewname = self::$views['TalkpageView'];
 88+ } else if ($request->getVal('lqt_method', null) === null &&
8689 ( in_array( $action, $header_actions ) ||
8790 $request->getVal('diff', null) !== null ) ) {
8891 $viewname = self::$views['TalkpageHeaderView'];

Follow-up revisions

RevisionCommit summaryAuthorDate
r39241* Revert r39133 - bogus fix that does not work....minuteelectron20:28, 12 August 2008

Status & tagging log