r39240 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39239‎ | r39240 | r39241 >
Date:20:13, 12 August 2008
Author:brion
Status:old
Tags:
Comment:
Revert r39198 "* (bug 15128) Feed:xmlEncode() function now declared as static"
FeedItem::xmlEncode() is only called *non*-statically
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Feed.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Feed.php
@@ -55,7 +55,7 @@
5656 /**
5757 * @static
5858 */
59 - static function xmlEncode( $string ) {
 59+ function xmlEncode( $string ) {
6060 $string = str_replace( "\r\n", "\n", $string );
6161 $string = preg_replace( '/[\x00-\x08\x0b\x0c\x0e-\x1f]/', '', $string );
6262 return htmlspecialchars( $string );
Index: trunk/phase3/RELEASE-NOTES
@@ -109,8 +109,7 @@
110110 * (bug 13770) Fixed incorrect detection of PHP's DOM module
111111 * (bug 14790) Export of category pages when using Category: prefix now actually
112112 gives results
113 -* (bug 15128) Feed::xmlEncode() function is now declared as static
114 -
 113+
115114 === API changes in 1.14 ===
116115
117116 * Registration time of users registered before the DB field was created is now

Follow-up revisions

RevisionCommit summaryAuthorDate
r39265(bug 15128) Documentation for xmlEncode is wrong, it's not static.simetrical01:53, 13 August 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r39198* (bug 15128) Feed:xmlEncode() function now declared as staticskizzerz01:47, 12 August 2008

Status & tagging log