r38321 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r38320‎ | r38321 | r38322 >
Date:23:20, 31 July 2008
Author:brion
Status:old
Tags:
Comment:
Revert r38302,38306 -- "Add an order by to the list of watched pages."
This looks wrong -- an order by title wouldn't be indexed properly, and could be rather slow.
Modified paths:
  • /trunk/phase3/includes/WatchlistEditor.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/WatchlistEditor.php
——@@ -208,9 +208,6 @@
209209 $sql = "SELECT wl_namespace, wl_title, page_id, page_len, page_is_redirect
210210 FROM {$watchlist} LEFT JOIN {$page} ON ( wl_namespace = page_namespace
211211 AND wl_title = page_title ) WHERE wl_user = {$uid}";
212 - if ( !$dbr->implicitOrderby() ) {
213 - $sql .= ' ORDER BY wl_title';
214 - }
215212 $res = $dbr->query( $sql, __METHOD__ );
216213 if( $res && $dbr->numRows( $res ) > 0 ) {
217214 $cache = LinkCache::singleton();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r38302Add an order by to the list of watched pages.greg16:14, 31 July 2008

Status & tagging log