r38302 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38301‎ | r38302 | r38303 >
Date:16:14, 31 July 2008
Author:greg
Status:old
Tags:
Comment:
Add an order by to the list of watched pages.
Modified paths:
  • /trunk/phase3/includes/WatchlistEditor.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/WatchlistEditor.php
@@ -208,6 +208,9 @@
209209 $sql = "SELECT wl_namespace, wl_title, page_id, page_len, page_is_redirect
210210 FROM {$watchlist} LEFT JOIN {$page} ON ( wl_namespace = page_namespace
211211 AND wl_title = page_title ) WHERE wl_user = {$uid}";
 212+ if ( ! $dbr->implicitOrderby() ) {
 213+ $sql .= "ORDER BY wl_title';
 214+ }
212215 $res = $dbr->query( $sql, __METHOD__ );
213216 if( $res && $dbr->numRows( $res ) > 0 ) {
214217 $cache = LinkCache::singleton();

Follow-up revisions

RevisionCommit summaryAuthorDate
r38306Fix r38302:...simetrical16:34, 31 July 2008
r38321Revert r38302,38306 -- "Add an order by to the list of watched pages."...brion23:20, 31 July 2008

Status & tagging log