r38322 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38321‎ | r38322 | r38323 >
Date:23:34, 31 July 2008
Author:brion
Status:old
Tags:
Comment:
Revert r38275, 38307 for now -- proper way to escape this stuff is being discussed.
Modified paths:
  • /trunk/extensions/CSS/CSS.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CSS/CSS.php
@@ -13,7 +13,7 @@
1414
1515 if (!defined('MEDIAWIKI')) die('Not an entry point.');
1616
17 -define('CSS_VERSION', '1.0.5, 2008-07-31');
 17+define('CSS_VERSION', '1.0.4, 2008-06-01');
1818
1919 $wgCSSMagic = "css";
2020 $wgExtensionFunctions[] = 'wfSetupCSS';
@@ -44,7 +44,9 @@
4545 $css = htmlspecialchars(trim(Sanitizer::checkCss($css)));
4646 $parser->mOutput->addHeadItem( <<<EOT
4747 <style type="text/css">
 48+/*<![CDATA[*/
4849 {$css}
 50+/*]]>*/
4951 </style>
5052 EOT
5153 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r38275I meant to say should *not* use htmlspecialchars, it makes invalid CSS syntax...nad03:36, 31 July 2008

Status & tagging log