r37830 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37829‎ | r37830 | r37831 >
Date:18:03, 18 July 2008
Author:demon
Status:old
Tags:
Comment:
$wgDefaultDirectoryChmod -> $wgDirectoryMode. Less crappy name + docs I should've written on the original commit.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -1771,18 +1771,18 @@
17721772 * Make directory, and make all parent directories if they don't exist
17731773 *
17741774 * @param string $fullDir Full path to directory to create
1775 - * @param int $mode Chmod value to use, default is $wgDefaultDirectoryChmod
 1775+ * @param int $mode Chmod value to use, default is $wgDirectoryMode
17761776 * @return bool
17771777 */
17781778 function wfMkdirParents( $fullDir, $mode = null ) {
1779 - global $wgDefaultDirectoryChmod;
 1779+ global $wgDirectoryMode;
17801780 if( strval( $fullDir ) === '' )
17811781 return true;
17821782 if( file_exists( $fullDir ) )
17831783 return true;
17841784 // If not defined or isn't an int, set to default
17851785 if ( !$mode || !is_int($mode) ) {
1786 - $mode = $wgDefaultDirectoryChmod;
 1786+ $mode = $wgDirectoryMode;
17871787 }
17881788
17891789
Index: trunk/phase3/includes/DefaultSettings.php
@@ -165,7 +165,7 @@
166166 /**
167167 * Default value for chmoding of new directories.
168168 */
169 -$wgDefaultDirectoryChmod = 0777;
 169+$wgDirectoryMode = 0777;
170170
171171 /**
172172 * New file storage paths; currently used only for deleted files.
Index: trunk/phase3/RELEASE-NOTES
@@ -66,6 +66,8 @@
6767 provided by extensions, in a similar way to $wgExtensionMessagesFiles
6868 * Added $wgXMLMimeTypes, an array of XML mimetypes we can check for
6969 with MimeMagic.
 70+* Added $wgDirectoryMode, which allows for setting the default CHMOD value when
 71+ creating new directories.
7072
7173 === New features in 1.13 ===
7274

Follow-up revisions

RevisionCommit summaryAuthorDate
r37838Cleanup for r37830 & earlier ($wgDirectoryMode default to wfMkdirParents()):...brion07:29, 19 July 2008

Status & tagging log