r37838 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r37837
|
r37838
|
r37839
>
Date:
07:29, 19 July 2008
Author:
brion
Status:
old
Tags:
Comment:
Cleanup for
r37830
& earlier ($wgDirectoryMode default to wfMkdirParents()):
Just check is_null() here. is_int() isn't necessarily safe, as numbers frequently get passed around in what are really strings. :)
Modified paths:
/trunk/phase3/includes/GlobalFunctions.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/includes/GlobalFunctions.php
—
—
@@ -1781,7 +1781,7 @@
1782
1782
if( file_exists( $fullDir ) )
1783
1783
return true;
1784
1784
// If not defined or isn't an int, set to default
1785
- if ( !$mode || !is_int($mode) ) {
1785
+ if ( is_null( $mode ) ) {
1786
1786
$mode = $wgDirectoryMode;
1787
1787
}
1788
1788
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r37830
$wgDefaultDirectoryChmod -> $wgDirectoryMode. Less crappy name + docs I shoul...
demon
18:03, 18 July 2008
Status & tagging log
15:29, 12 September 2011
Meno25
(
talk
|
contribs
)
changed the
status
of r37838
[
removed:
ok
added:
old]