r37385 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37384‎ | r37385 | r37386 >
Date:12:27, 9 July 2008
Author:demon
Status:old
Tags:
Comment:
Fix regression from r37158, Article::lastModified() now works on non-mySQL schemas again. Patch by OverlordQ.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -1205,7 +1205,8 @@
12061206 function lastModified() {
12071207 global $wgLang, $wgArticle;
12081208 if( $this->mRevisionId ) {
1209 - $timestamp = Revision::getTimestampFromId( $this->mRevisionId, $wgArticle->getId() );
 1209+ $timestamp = wfTimestamp( TS_MW,
 1210+ Revision::getTimestampFromId( $this->mRevisionId, $wgArticle->getId() ) );
12101211 } else {
12111212 $timestamp = $wgArticle->getTimestamp();
12121213 }
Index: trunk/phase3/RELEASE-NOTES
@@ -427,6 +427,8 @@
428428 * (bug 14745) Image moving works on sites that transform thumbnails via 404
429429 * (bug 2186) Document.write() in wikibits caused failures when using
430430 application/xhtml+xml. The calls to this have been removed.
 431+* (bug 14764) Fix regression in from Article::lastModified(), failed to work
 432+ on non-mySQL schemas.
431433
432434 === API changes in 1.13 ===
433435

Follow-up revisions

RevisionCommit summaryAuthorDate
r37419Tweak to r37385: put the timestamp format normalization on the input read (Re...brion17:41, 9 July 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r37158FlaggedRevs refactoring:...aaron11:01, 6 July 2008

Status & tagging log