r37017 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37016‎ | r37017 | r37018 >
Date:02:25, 4 July 2008
Author:demon
Status:old
Tags:
Comment:
Remove wfGetHTTP() and wfIsLocalUrl(). Unused wrapper functions for stuff in the Http class.
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -2293,16 +2293,6 @@
22942294 }
22952295 }
22962296
2297 -/**
2298 - * Aliases for modularized functions
2299 - */
2300 -function wfGetHTTP( $url, $timeout = 'default' ) {
2301 - return Http::get( $url, $timeout );
2302 -}
2303 -function wfIsLocalURL( $url ) {
2304 - return Http::isLocalURL( $url );
2305 -}
2306 -
23072297 function wfHttpOnlySafe() {
23082298 global $wgHttpOnlyBlacklist;
23092299 if( !version_compare("5.2", PHP_VERSION, "<") )

Follow-up revisions

RevisionCommit summaryAuthorDate
r37018Revert r37017. Please do not remove functions unless you have a really really...tstarling02:52, 4 July 2008
r37019Trying to resolve commit r37017/revert r37018: Throw an E_USER_NOTICE saying ...siebrand06:47, 4 July 2008

Status & tagging log