r37018 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r37017‎ | r37018 | r37019 >
Date:02:52, 4 July 2008
Author:tstarling
Status:old
Tags:
Comment:
Revert r37017. Please do not remove functions unless you have a really really good reason, say because you actually want to break all extensions that use them because the underlying functionality needs to be removed. There are more extensions out of Wikimedia version control than in it, and many sysadmins will not update their extensions simultaneously with the core.
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
——@@ -2293,6 +2293,16 @@
22942294 }
22952295 }
22962296
 2297+/**
 2298+ * Aliases for modularized functions
 2299+ */
 2300+function wfGetHTTP( $url, $timeout = 'default' ) {
 2301+ return Http::get( $url, $timeout );
 2302+}
 2303+function wfIsLocalURL( $url ) {
 2304+ return Http::isLocalURL( $url );
 2305+}
 2306+
22972307 function wfHttpOnlySafe() {
22982308 global $wgHttpOnlyBlacklist;
22992309 if( !version_compare("5.2", PHP_VERSION, "<") )

Follow-up revisions

RevisionCommit summaryAuthorDate
r37019Trying to resolve commit r37017/revert r37018: Throw an E_USER_NOTICE saying ...siebrand06:47, 4 July 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r37017Remove wfGetHTTP() and wfIsLocalUrl(). Unused wrapper functions for stuff in ...demon02:25, 4 July 2008

Status & tagging log