r36916 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36915‎ | r36916 | r36917 >
Date:14:40, 2 July 2008
Author:demon
Status:old
Tags:
Comment:
(bug 14698) Make "Block account creation" work as advertised. :)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
@@ -407,6 +407,8 @@
408408 * (bug 14687) OutputPage::addStyle() now adds type="text/css" like it should.
409409 * OpenSearch cleanup; Firefox now sends you to the search page for empty
410410 searches instead of the domain root (which may not even be a wiki).
 411+* (bug 14698) Blocks without "block account creation" set no longer block
 412+ account creation.
411413
412414
413415 === API changes in 1.13 ===
Index: trunk/phase3/includes/specials/SpecialUserlogin.php
@@ -727,7 +727,9 @@
728728 } elseif ( $wgUser->isBlockedFromCreateAccount() ) {
729729 $this->userBlockedMessage();
730730 return;
731 - } elseif ( count( $permErrors = $titleObj->getUserPermissionsErrors( 'createaccount', $wgUser, true ) )>0 ) {
 731+ }
 732+ // Supress 'blockedtext' error here, we already checked above.
 733+ elseif ( count( $permErrors = $titleObj->getUserPermissionsErrors( 'createaccount', $wgUser, true, array('blockedtext') ) )>0 ) {
732734 $wgOut->showPermissionsErrorPage( $permErrors, 'createaccount' );
733735 return;
734736 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r36955Fix a misspelled word in a comment added by r36916.simetrical22:35, 2 July 2008
r37002Revert r36916 for now ("(bug 14698) Make "Block account creation" work as adv...brion20:10, 3 July 2008

Status & tagging log