r37002 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37001‎ | r37002 | r37003 >
Date:20:10, 3 July 2008
Author:brion
Status:old
Tags:
Comment:
Revert r36916 for now ("(bug 14698) Make "Block account creation" work as advertised. :) ")
This doesn't appear to be working the right way; it's finding that permission is not allowed, but then trying to ignore particular reasons why it might not be allowed.
Correct fix should be to ensure that the correct result is actually obtained from the permission check in the first place!
Note that the error key may have 'autoblocktext' for autoblocks, which would not match this check as written.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserlogin.php
@@ -727,9 +727,7 @@
728728 } elseif ( $wgUser->isBlockedFromCreateAccount() ) {
729729 $this->userBlockedMessage();
730730 return;
731 - }
732 - // Suppress 'blockedtext' error here, we already checked above.
733 - elseif ( count( $permErrors = $titleObj->getUserPermissionsErrors( 'createaccount', $wgUser, true, array('blockedtext') ) )>0 ) {
 731+ } elseif ( count( $permErrors = $titleObj->getUserPermissionsErrors( 'createaccount', $wgUser, true ) )>0 ) {
734732 $wgOut->showPermissionsErrorPage( $permErrors, 'createaccount' );
735733 return;
736734 }
Index: trunk/phase3/RELEASE-NOTES
@@ -405,8 +405,6 @@
406406 * (bug 14687) OutputPage::addStyle() now adds type="text/css" like it should.
407407 * OpenSearch cleanup; Firefox now sends you to the search page for empty
408408 searches instead of the domain root (which may not even be a wiki).
409 -* (bug 14698) Blocks without "block account creation" set no longer block
410 - account creation.
411409 * (bug 3481) Pages moved shortly after creation are shown at their new title
412410 on Special:Newpages.
413411 * (bug 12716) Trying to unprotect a title that isn't protected no longer

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r36916(bug 14698) Make "Block account creation" work as advertised. :)demon14:40, 2 July 2008

Status & tagging log