r36296 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36295‎ | r36296 | r36297 >
Date:21:31, 14 June 2008
Author:grondin
Status:old
Tags:
Comment:
Fix bug : extension didn't run
Modified paths:
  • /trunk/extensions/ExtensionDistributor/ExtensionDistributor.i18n.php (modified) (history)
  • /trunk/extensions/ExtensionDistributor/ExtensionDistributor.php (modified) (history)
  • /trunk/extensions/ExtensionDistributor/ExtensionDistributor_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ExtensionDistributor/ExtensionDistributor_body.php
@@ -5,14 +5,13 @@
66
77 function __construct() {
88 parent::__construct( 'ExtensionDistributor' );
 9+ wfLoadExtensionMessages( 'ExtensionDistributor' );
 10+ $this->setHeaders();
911 }
1012
1113 function execute( $subpage ) {
1214 global $wgExtDistTarDir, $wgExtDistWorkingCopy, $wgOut, $wgRequest;
1315
14 - wfLoadExtensionMessages( 'ExtensionDistributor' );
15 - $this->setHeaders();
16 -
1716 if ( !$wgExtDistTarDir || !$wgExtDistWorkingCopy ) {
1817 $wgOut->addWikiMsg( 'extdist-not-configured' );
1918 return;
Index: trunk/extensions/ExtensionDistributor/ExtensionDistributor.i18n.php
@@ -1,7 +1,8 @@
22 <?php
33
4 -$messages = array(
5 - 'en' => array(
 4+$messages = array();
 5+
 6+$messages['en'] = array(
67 'extensiondistributor' => 'Download MediaWiki extension',
78 'extdist-desc' => 'Extension for distributing snapshot archives of extensions',
89 'extdist-not-configured' => 'Please configure $wgExtDistTarDir and $wgExtDistWorkingCopy',
@@ -35,5 +36,4 @@
3637 The tar archive should be extracted into your extensions directory, then follow the extension's documentation to enable it in MediaWiki.
3738 ",
3839 'extdist-want-more' => 'Get another extension',
39 - ),
4040 );
Index: trunk/extensions/ExtensionDistributor/ExtensionDistributor.php
@@ -10,15 +10,6 @@
1111 * Configuration
1212 */
1313
14 -$wgExtensionCredits['specialpage'][] = array(
15 - 'name' => 'Extension Distributor',
16 - 'author' => 'Tim Starling',
17 - 'svn-revision' => '$LastChangedRevision: 35631 $',
18 - 'url' => 'http://www.mediawiki.org/wiki/Extension:ExtensionDistributor',
19 - 'description' => 'This is an extension for distributing snapshot archives of extensions',
20 - 'descriptionmsg' => 'extdist-desc',
21 -);
22 -
2314 /** Directory to put tar files in */
2415 $wgExtDistTarDir = false;
2516
@@ -58,3 +49,12 @@
5950 $wgAutoloadClasses['ExtensionDistributorPage'] = dirname(__FILE__).'/ExtensionDistributor_body.php';
6051 $wgExtensionMessagesFiles['ExtensionDistributor'] = dirname(__FILE__).'/ExtensionDistributor.i18n.php';
6152
 53+$wgExtensionCredits['specialpage'][] = array(
 54+ 'name' => 'Extension Distributor',
 55+ 'author' => 'Tim Starling',
 56+ 'svn-revision' => '$LastChangedRevision: 35631 $',
 57+ 'url' => 'http://www.mediawiki.org/wiki/Extension:ExtensionDistributor',
 58+ 'description' => 'This is an extension for distributing snapshot archives of extensions',
 59+ 'descriptionmsg' => 'extdist-desc',
 60+);
 61+

Follow-up revisions

RevisionCommit summaryAuthorDate
r36297revert r36296 to r36275grondin22:13, 14 June 2008

Status & tagging log