r36295 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36294‎ | r36295 | r36296 >
Date:19:07, 14 June 2008
Author:jojo
Status:old
Tags:
Comment:
remove shared base URL stuff, which is not needed any more by newest mwlib code
Modified paths:
  • /trunk/extensions/Collection/Collection.body.php (modified) (history)
  • /trunk/extensions/Collection/Collection.php (modified) (history)
  • /trunk/extensions/Collection/README.txt (modified) (history)
  • /trunk/extensions/Collection/pdf-server/pdfserver.py (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.php
@@ -46,9 +46,6 @@
4747 /** Maximum no. of articles in a collection */
4848 $wgCollectionMaxArticles = 500;
4949
50 -/** Base URL for shared media MediaWiki */
51 -$wgSharedBaseURL = 'http://commons.wikimedia.org/w/';
52 -
5350 /** License article */
5451 $wgLicenseArticle = 'MediaWiki:GFDL';
5552
Index: trunk/extensions/Collection/README.txt
@@ -78,12 +78,6 @@
7979
8080 Default is 500.
8181
82 - *$wgSharedBaseURL (string)*
83 - Base URL (i.e. URL up to but not including ``index.php``/``api.php``) of a
84 - MediaWiki used for shared files.
85 -
86 - Default is ``http://commons.mediawiki.org/w/``
87 -
8882 *$wgLicenseArticle (string)*
8983 Title of an article containing the full license text for articles in this
9084 MediaWiki. For a Wikimedia Commons wiki this could be ``Wikipedia:GFDL``.
Index: trunk/extensions/Collection/Collection.body.php
@@ -485,13 +485,11 @@
486486 global $wgServer;
487487 global $wgScriptPath;
488488 global $wgLicenseArticle;
489 - global $wgSharedBaseURL;
490489 global $wgPDFTemplateBlacklist;
491490
492491 $response = self::pdfServerCommand( 'pdf_generate', array(
493492 'metabook' => $this->buildJSONCollection( $collection ),
494493 'base_url' => $wgServer . $wgScriptPath,
495 - 'shared_base_url' => $wgSharedBaseURL,
496494 'template_blacklist' => $wgPDFTemplateBlacklist,
497495 'license' => $wgLicenseArticle,
498496 ) );
@@ -627,7 +625,6 @@
628626 global $wgScriptPath;
629627 global $wgOut;
630628 global $wgLicenseArticle;
631 - global $wgSharedBaseURL;
632629 global $wgPDFTemplateBlacklist;
633630
634631 $json = new Services_JSON();
@@ -649,7 +646,6 @@
650647 $response = self::pdfServerCommand( 'zip_post', array(
651648 'metabook' => $this->buildJSONCollection( $_SESSION['wsCollection'] ),
652649 'base_url' => $wgServer . $wgScriptPath,
653 - 'shared_base_url' => $wgSharedBaseURL,
654650 'template_blacklist' => $wgPDFTemplateBlacklist,
655651 'license' => $wgLicenseArticle,
656652 'post_url' => $postData->post_url,
Index: trunk/extensions/Collection/pdf-server/pdfserver.py
@@ -137,7 +137,6 @@
138138 if not base_url:
139139 return self.error_response('base_url argument required')
140140
141 - shared_base_url = self.form.getvalue('shared_base_url')
142141 license = self.form.getvalue('license')
143142 if not license:
144143 return self.error_response('license argument required')
@@ -161,8 +160,6 @@
162161 '--progress', self.get_path(collection_id, self.progress_filename),
163162 '--output', self.get_path(collection_id, self.pdf_filename),
164163 ]
165 - if shared_base_url:
166 - args.extend(['--shared-baseurl', shared_base_url])
167164 if template_blacklist:
168165 args.extend(['--template-blacklist', template_blacklist])
169166
@@ -215,7 +212,6 @@
216213 base_url = self.form.getvalue('base_url')
217214 if not base_url:
218215 return self.error_response('base_url argument required')
219 - shared_base_url = self.form.getvalue('shared_base_url')
220216 license = self.form.getvalue('license')
221217 if not license:
222218 return self.error_response('license argument required')
@@ -238,8 +234,6 @@
239235 '--license', license,
240236 '--posturl', post_url,
241237 ]
242 - if shared_base_url:
243 - args.extend(['--shared-baseurl', shared_base_url])
244238 if template_blacklist:
245239 args.extend(['--template-blacklist', template_blacklist])
246240 rc = subprocess.call(executable=mwzip_cmd, args=args)

Status & tagging log