r35812 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r35811‎ | r35812 | r35813 >
Date:18:55, 3 June 2008
Author:alnokta
Status:old
Tags:
Comment:
Enable external link icon (along with other links icons too) again on RTL wikis after correcting its behavior.
This time it only adds 1.7kb of code. tested it on Arabic and English wikis. patch by Ahmad Sherif.
Modified paths:
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/rtl.css
@@ -156,11 +156,7 @@
157157 #p-personal li {
158158 float: left;
159159 }
160 -/* Fix link icons */
161 -.external {
162 - padding: 0 !important;
163 - background: none !important;
164 -}
 160+
165161 #footer {
166162 clear: both;
167163 }
Index: trunk/phase3/skins/monobook/main.css
@@ -551,32 +551,32 @@
552552 #bodyContent a.external,
553553 #bodyContent a[href ^="gopher://"] {
554554 background: url(external.png) center right no-repeat;
555 - padding-right: 13px;
 555+ padding: 0 13px;
556556 }
557557 #bodyContent a[href ^="https://"],
558558 .link-https {
559559 background: url(lock_icon.gif) center right no-repeat;
560 - padding-right: 16px;
 560+ padding: 0 16px;
561561 }
562562 #bodyContent a[href ^="mailto:"],
563563 .link-mailto {
564564 background: url(mail_icon.gif) center right no-repeat;
565 - padding-right: 18px;
 565+ padding: 0 18px;
566566 }
567567 #bodyContent a[href ^="news://"] {
568568 background: url(news_icon.png) center right no-repeat;
569 - padding-right: 18px;
 569+ padding: 0 18px;
570570 }
571571 #bodyContent a[href ^="ftp://"],
572572 .link-ftp {
573573 background: url(file_icon.gif) center right no-repeat;
574 - padding-right: 18px;
 574+ padding: 0 18px;
575575 }
576576 #bodyContent a[href ^="irc://"],
577577 #bodyContent a.extiw[href ^="irc://"],
578578 .link-irc {
579579 background: url(discussionitem_icon.gif) center right no-repeat;
580 - padding-right: 18px;
 580+ padding: 0 18px;
581581 }
582582 #bodyContent a.external[href $=".ogg"], #bodyContent a.external[href $=".OGG"],
583583 #bodyContent a.external[href $=".mid"], #bodyContent a.external[href $=".MID"],
@@ -586,7 +586,7 @@
587587 #bodyContent a.external[href $=".wma"], #bodyContent a.external[href $=".WMA"],
588588 .link-audio {
589589 background: url("audio.png") center right no-repeat;
590 - padding-right: 13px;
 590+ padding: 0 13px;
591591 }
592592 #bodyContent a.external[href $=".ogm"], #bodyContent a.external[href $=".OGM"],
593593 #bodyContent a.external[href $=".avi"], #bodyContent a.external[href $=".AVI"],
@@ -594,16 +594,26 @@
595595 #bodyContent a.external[href $=".mpg"], #bodyContent a.external[href $=".MPG"],
596596 .link-video {
597597 background: url("video.png") center right no-repeat;
598 - padding-right: 13px;
 598+ padding: 0 13px;
599599 }
600600 #bodyContent a.external[href $=".pdf"], #bodyContent a.external[href $=".PDF"],
601601 #bodyContent a.external[href *=".pdf#"], #bodyContent a.external[href *=".PDF#"],
602602 #bodyContent a.external[href *=".pdf?"], #bodyContent a.external[href *=".PDF?"],
603603 .link-document {
604604 background: url("document.png") center right no-repeat;
605 - padding-right: 12px;
 605+ padding: 0 12px;
606606 }
607607
 608+/* for rtl wikis */
 609+.rtl #bodyContent a.external {
 610+ background-position: left;
 611+ padding-right: 0;
 612+}
 613+/* correction for ltr wikis */
 614+.ltr #bodyContent a.external {
 615+ padding-left: 0;
 616+}
 617+
608618 /* disable interwiki styling */
609619 #bodyContent a.extiw,
610620 #bodyContent a.extiw:active {

Follow-up revisions

RevisionCommit summaryAuthorDate
r35827Revert r35812 (link icons for RTL)....brion23:36, 3 June 2008

Status & tagging log