r35277 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r35276‎ | r35277 | r35278 >
Date:09:37, 24 May 2008
Author:leon
Status:old
Tags:
Comment:
Paging links on special pages now have CSS classes and are greyed out by default when disabled. Somehow related to bug 14244.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Pager.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -244,3 +244,8 @@
245245 #shared-image-dup, #shared-image-conflict {
246246 font-style: italic;
247247 }
 248+
 249+span.mw-pager-pagerlink-disabled {
 250+ color: #aaa;
 251+}
 252+
Index: trunk/phase3/includes/Pager.php
@@ -405,11 +405,17 @@
406406 $links = array();
407407 foreach ( $queries as $type => $query ) {
408408 if ( $query !== false ) {
409 - $links[$type] = $this->makeLink( $linkTexts[$type], $queries[$type], $type );
 409+ $links[$type] = "<span class='mw-pager-pagerlink-enabled'>" .
 410+ $this->makeLink( $linkTexts[$type], $queries[$type], $type ) .
 411+ "</span>";
410412 } elseif ( isset( $disabledTexts[$type] ) ) {
411 - $links[$type] = $disabledTexts[$type];
 413+ $links[$type] = "<span class='mw-pager-pagerlink-disabled'>" .
 414+ $disabledTexts[$type] .
 415+ "</span>";
412416 } else {
413 - $links[$type] = $linkTexts[$type];
 417+ $links[$type] = "<span class='mw-pager-pagerlink-disabled'>" .
 418+ $linkTexts[$type] .
 419+ "</span>";
414420 }
415421 }
416422 return $links;
Index: trunk/phase3/RELEASE-NOTES
@@ -127,6 +127,8 @@
128128 * (bug 13095) Search by first letters or digits in [[Special:Categories]]
129129 * Users moving a page can now move all subpages automatically as well
130130 * Sidebar is now cached for all languages
 131+* Paging links on special pages now have CSS classes and are greyed out by default
 132+ when disabled
131133
132134 === Bug fixes in 1.13 ===
133135

Follow-up revisions

RevisionCommit summaryAuthorDate
r35322Revert r35277 (grayed-out paging links). IMHO this just doesn't look very good.brion17:00, 25 May 2008

Status & tagging log