r35322 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r35321‎ | r35322 | r35323 >
Date:17:00, 25 May 2008
Author:brion
Status:old
Tags:
Comment:
Revert r35277 (grayed-out paging links). IMHO this just doesn't look very good.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Pager.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -244,8 +244,3 @@
245245 #shared-image-dup, #shared-image-conflict {
246246 font-style: italic;
247247 }
248 -
249 -span.mw-pager-pagerlink-disabled {
250 - color: #989898;
251 -}
252 -
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1328,7 +1328,7 @@
13291329 * to ensure that client-side caches don't keep obsolete copies of global
13301330 * styles.
13311331 */
1332 -$wgStyleVersion = '147';
 1332+$wgStyleVersion = '148';
13331333
13341334
13351335 # Server-side caching:
Index: trunk/phase3/includes/Pager.php
@@ -405,17 +405,11 @@
406406 $links = array();
407407 foreach ( $queries as $type => $query ) {
408408 if ( $query !== false ) {
409 - $links[$type] = "<span class='mw-pager-pagerlink-enabled'>" .
410 - $this->makeLink( $linkTexts[$type], $queries[$type], $type ) .
411 - "</span>";
 409+ $links[$type] = $this->makeLink( $linkTexts[$type], $queries[$type], $type );
412410 } elseif ( isset( $disabledTexts[$type] ) ) {
413 - $links[$type] = "<span class='mw-pager-pagerlink-disabled'>" .
414 - $disabledTexts[$type] .
415 - "</span>";
 411+ $links[$type] = $disabledTexts[$type];
416412 } else {
417 - $links[$type] = "<span class='mw-pager-pagerlink-disabled'>" .
418 - $linkTexts[$type] .
419 - "</span>";
 413+ $links[$type] = $linkTexts[$type];
420414 }
421415 }
422416 return $links;
Index: trunk/phase3/RELEASE-NOTES
@@ -127,8 +127,6 @@
128128 * (bug 13095) Search by first letters or digits in [[Special:Categories]]
129129 * Users moving a page can now move all subpages automatically as well
130130 * Sidebar is now cached for all languages
131 -* Paging links on special pages now have CSS classes and are greyed out by default
132 - when disabled
133131 * (bug 14259) Localisation message for upload button on Special:Import is now 'import-upload'
134132 instead of 'upload'
135133

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r35277Paging links on special pages now have CSS classes and are greyed out by defa...leon09:37, 24 May 2008

Status & tagging log