r34849 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34848‎ | r34849 | r34850 >
Date:07:47, 15 May 2008
Author:raymond
Status:old
Tags:
Comment:
Use headings per section, improves navigation by screenreaders too.
Modified paths:
  • /trunk/phase3/includes/ImagePage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImagePage.php
@@ -577,7 +577,7 @@
578578 $wgOut->addWikiMsg( 'nolinkstoimage' );
579579 return;
580580 }
581 - $wgOut->addWikiMsg( 'linkstoimage' );
 581+ $wgOut->addHTML( Xml::element( 'h5', null, wfMsg( 'linkstoimage' ) ) . "\n" );
582582 $wgOut->addHTML( "<ul class='mw-imagepage-linktoimage'>\n" );
583583
584584 $sk = $wgUser->getSkin();
@@ -615,12 +615,11 @@
616616 ),
617617 __METHOD__
618618 );
619 -
620619
621620 if ( 0 == $dbr->numRows( $res ) )
622621 return;
623622
624 - $wgOut->addWikiMsg( 'redirectstofile' );
 623+ $wgOut->addHTML( Xml::element( 'h5', null, wfMsg( 'redirectstofile' ) ) . "\n" );
625624 $wgOut->addHTML( "<ul class='mw-imagepage-redirectstofile'>\n" );
626625
627626 $sk = $wgUser->getSkin();
@@ -652,7 +651,7 @@
653652 }
654653 if ( count( $dupes ) == 0 ) return;
655654
656 - $wgOut->addWikiMsg( 'duplicatesoffile' );
 655+ $wgOut->addHTML( Xml::element( 'h5', null, wfMsg( 'duplicatesoffile' ) ) . "\n" );
657656 $wgOut->addHTML( "<ul class='mw-imagepage-duplicates'>\n" );
658657
659658 $sk = $wgUser->getSkin();

Follow-up revisions

RevisionCommit summaryAuthorDate
r34880Revert r34849 -- please stop randomly changing formatted messages into plaint...brion18:38, 15 May 2008

Status & tagging log