r34880 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34879‎ | r34880 | r34881 >
Date:18:38, 15 May 2008
Author:brion
Status:old
Tags:
Comment:
Revert r34849 -- please stop randomly changing formatted messages into plaintext, especially without checking usage.
Modified paths:
  • /trunk/phase3/includes/ImagePage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImagePage.php
@@ -577,7 +577,7 @@
578578 $wgOut->addWikiMsg( 'nolinkstoimage' );
579579 return;
580580 }
581 - $wgOut->addHTML( Xml::element( 'h5', null, wfMsg( 'linkstoimage' ) ) . "\n" );
 581+ $wgOut->addWikiMsg( 'linkstoimage' );
582582 $wgOut->addHTML( "<ul class='mw-imagepage-linktoimage'>\n" );
583583
584584 $sk = $wgUser->getSkin();
@@ -615,11 +615,12 @@
616616 ),
617617 __METHOD__
618618 );
 619+
619620
620621 if ( 0 == $dbr->numRows( $res ) )
621622 return;
622623
623 - $wgOut->addHTML( Xml::element( 'h5', null, wfMsg( 'redirectstofile' ) ) . "\n" );
 624+ $wgOut->addWikiMsg( 'redirectstofile' );
624625 $wgOut->addHTML( "<ul class='mw-imagepage-redirectstofile'>\n" );
625626
626627 $sk = $wgUser->getSkin();
@@ -651,7 +652,7 @@
652653 }
653654 if ( count( $dupes ) == 0 ) return;
654655
655 - $wgOut->addHTML( Xml::element( 'h5', null, wfMsg( 'duplicatesoffile' ) ) . "\n" );
 656+ $wgOut->addWikiMsg( 'duplicatesoffile' );
656657 $wgOut->addHTML( "<ul class='mw-imagepage-duplicates'>\n" );
657658
658659 $sk = $wgUser->getSkin();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r34849Use headings per section, improves navigation by screenreaders too.raymond07:47, 15 May 2008

Status & tagging log