r34751 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34750‎ | r34751 | r34752 >
Date:18:59, 13 May 2008
Author:brion
Status:old
Tags:
Comment:
Cleanup r34661 (bug 14063 -- <label> for powersearch redirect checkbox)

Got rid of the old weird messages that combined localization with layout. Layout's now in nice clean code, with localization in nice clean messages. Yay!
Modified paths:
  • /trunk/phase3/includes/SpecialSearch.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialSearch.php
@@ -593,21 +593,27 @@
594594 }
595595
596596 $redirect = Xml::check( 'redirs', $this->searchRedirects, array( 'value' => '1', 'id' => 'redirs' ) );
597 - $redirectLabel = Xml::label( wfMsg( 'powersearchtext-redir' ), 'redirs' );
 597+ $redirectLabel = Xml::label( wfMsg( 'powersearch-redir' ), 'redirs' );
598598 $searchField = Xml::input( 'search', 50, $term, array( 'type' => 'text', 'id' => 'powerSearchText' ) );
599599 $searchButton = Xml::submitButton( wfMsg( 'powersearch' ), array( 'name' => 'fulltext' ) ) . "\n";
600600
601601 $out = Xml::openElement( 'form', array( 'id' => 'powersearch', 'method' => 'get', 'action' => $wgScript ) ) .
602 - Xml::openElement( 'fieldset' ) .
603 - Xml::element( 'legend', array( ), wfMsg( 'powersearch-legend' ) ) .
604 - Xml::hidden( 'title', 'Special:Search' ) .
605 - wfMsgExt( 'powersearchtext-ns', array( 'parse', 'replaceafter' ), $namespaces) .
606 - Xml::openElement( 'p' ) .
607 - $redirect . " " . $redirectLabel .
608 - Xml::closeElement( 'p') .
609 - wfMsgExt( 'powersearchtext-field', array( 'parse', 'replaceafter' ), $searchField, $searchButton) .
610 - Xml::closeElement( 'fieldset' ) .
611 - Xml::closeElement( 'form' );
 602+ Xml::fieldset( wfMsg( 'powersearch-legend' ),
 603+ Xml::hidden( 'title', 'Special:Search' ) .
 604+ "<p>" .
 605+ wfMsgExt( 'powersearch-ns', array( 'parseinline' ) ) .
 606+ "<br />" .
 607+ $namespaces .
 608+ "</p>" .
 609+ "<p>" .
 610+ $redirect . " " . $redirectLabel .
 611+ "</p>" .
 612+ wfMsgExt( 'powersearch-field', array( 'parseinline' ) ) .
 613+ "&nbsp;" .
 614+ $searchField .
 615+ "&nbsp;" .
 616+ $searchButton ) .
 617+ "</form>";
612618
613619 return $out;
614620 }
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1318,9 +1318,9 @@
13191319 'nonefound' => "'''Note''': Only some namespaces are searched by default. Try prefixing your query with ''all:'' to search all content (including talk pages, templates, etc), or use the desired namespace as prefix.",
13201320 'powersearch' => 'Advanced search',
13211321 'powersearch-legend' => 'Advanced search',
1322 -'powersearchtext-ns' => 'Search in namespaces:<br />$1<br />',
1323 -'powersearchtext-redir' => 'List redirects',
1324 -'powersearchtext-field' => 'Search for $1 $2',
 1322+'powersearch-ns' => 'Search in namespaces:',
 1323+'powersearch-redir' => 'List redirects',
 1324+'powersearch-field' => 'Search for',
13251325 'search-external' => 'External search',
13261326 'searchdisabled' => '{{SITENAME}} search is disabled.
13271327 You can search via Google in the meantime.

Follow-up revisions

RevisionCommit summaryAuthorDate
r34752* Localisation updates German...raymond19:02, 13 May 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r34661(bug 14063) Power search form missing <label> for redirects checkhuji14:28, 12 May 2008

Status & tagging log