r34661 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34660‎ | r34661 | r34662 >
Date:14:28, 12 May 2008
Author:huji
Status:old
Tags:
Comment:
(bug 14063) Power search form missing <label> for redirects check
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialSearch.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialSearch.php
@@ -592,7 +592,8 @@
593593 Xml::closeElement( 'span' ) . "\n";
594594 }
595595
596 - $redirect = Xml::check( 'redirs', $this->searchRedirects, array( 'value' => '1' ) );
 596+ $redirect = Xml::check( 'redirs', $this->searchRedirects, array( 'value' => '1', 'id' => 'redirs' ) );
 597+ $redirectLabel = Xml::label( wfMsg( 'powersearchtext-redir' ), 'redirs' );
597598 $searchField = Xml::input( 'search', 50, $term, array( 'type' => 'text', 'id' => 'powerSearchText' ) );
598599 $searchButton = Xml::submitButton( wfMsg( 'powersearch' ), array( 'name' => 'fulltext' ) ) . "\n";
599600
@@ -600,10 +601,11 @@
601602 Xml::openElement( 'fieldset' ) .
602603 Xml::element( 'legend', array( ), wfMsg( 'powersearch-legend' ) ) .
603604 Xml::hidden( 'title', 'Special:Search' ) .
604 - wfMsgExt( 'powersearchtext', array( 'parse', 'replaceafter' ),
605 - $namespaces, $redirect, $searchField,
606 - '', '', '', '', '', # Dummy placeholders
607 - $searchButton ) .
 605+ wfMsgExt( 'powersearchtext-ns', array( 'parse', 'replaceafter' ), $namespaces) .
 606+ Xml::openElement( 'p' ) .
 607+ $redirect . " " . $redirectLabel .
 608+ Xml::closeElement( 'p') .
 609+ wfMsgExt( 'powersearchtext-field', array( 'parse', 'replaceafter' ), $searchField, $searchButton) .
608610 Xml::closeElement( 'fieldset' ) .
609611 Xml::closeElement( 'form' );
610612
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1318,7 +1318,9 @@
13191319 'nonefound' => "'''Note''': Only some namespaces are searched by default. Try prefixing your query with ''all:'' to search all content (including talk pages, templates, etc), or use the desired namespace as prefix.",
13201320 'powersearch' => 'Advanced search',
13211321 'powersearch-legend' => 'Advanced search',
1322 -'powersearchtext' => 'Search in namespaces:<br />$1<br />$2 List redirects<br />Search for $3 $9',
 1322+'powersearchtext-ns' => 'Search in namespaces:<br />$1<br />',
 1323+'powersearchtext-redir' => 'List redirects',
 1324+'powersearchtext-field' => 'Search for $1 $2',
13231325 'search-external' => 'External search',
13241326 'searchdisabled' => '{{SITENAME}} search is disabled.
13251327 You can search via Google in the meantime.
Index: trunk/phase3/RELEASE-NOTES
@@ -270,6 +270,7 @@
271271 * Message name filter on Special:Allmessages now case-insensitive
272272 * (bug 13943) Fix image redirect behaviour on image pages
273273 * (bug 14093) Do 'sysop' => 'protect' magic in Title::isValidMoveOperation
 274+* (bug 14063) Power search form missing <label> for redirects check
274275
275276 === API changes in 1.13 ===
276277

Follow-up revisions

RevisionCommit summaryAuthorDate
r34751Cleanup r34661 (bug 14063 -- <label> for powersearch redirect checkbox)...brion18:59, 13 May 2008

Status & tagging log