r34750 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34749‎ | r34750 | r34751 >
Date:18:51, 13 May 2008
Author:raymond
Status:old
Tags:
Comment:
Do not add an empty class=''
Modified paths:
  • /trunk/phase3/includes/SpecialNewpages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialNewpages.php
@@ -244,9 +244,9 @@
245245 $ulink = $this->skin->userLink( $result->rc_user, $result->rc_user_text ) . ' ' .
246246 $this->skin->userToolLinks( $result->rc_user, $result->rc_user_text );
247247 $comment = $this->skin->commentBlock( $result->rc_comment );
248 - $css = $this->patrollable( $result ) ? 'not-patrolled' : '';
 248+ $css = $this->patrollable( $result ) ? " class='not-patrolled'" : '';
249249
250 - return "<li class='$css'>{$time} {$dm}{$plink} ({$hist}) {$dm}[{$length}] {$dm}{$ulink} {$comment}</li>\n";
 250+ return "<li{$css}>{$time} {$dm}{$plink} ({$hist}) {$dm}[{$length}] {$dm}{$ulink} {$comment}</li>\n";
251251 }
252252
253253 /**

Status & tagging log