r34402 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34401‎ | r34402 | r34403 >
Date:21:58, 7 May 2008
Author:aaron
Status:old
Tags:
Comment:
More UI cleanup
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticle.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/flaggedrevs.css (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -178,7 +178,7 @@
179179 #########
180180
181181 # Bump this number every time you change flaggedrevs.css/flaggedrevs.js
182 -$wgFlaggedRevStyleVersion = 17;
 182+$wgFlaggedRevStyleVersion = 18;
183183
184184 $wgExtensionFunctions[] = 'efLoadFlaggedRevs';
185185
Index: trunk/extensions/FlaggedRevs/flaggedrevs.css
@@ -109,7 +109,7 @@
110110 padding: 5px;
111111 font-size: 95%;
112112 font-weight: normal;
113 - margin: 0em 0em .5em 1em;
 113+ margin: 0em 0em 1em 1em;
114114 position: relative;
115115 float: right;
116116 text-align: left;
@@ -195,7 +195,8 @@
196196 /* Both User Interfaces */
197197 .flaggedrevs_toggle {
198198 color: blue;
199 - white-space: no-wrap;
 199+ white-space: nowrap;
 200+ cursor:pointer;
200201 }
201202
202203 .fr-icon-current,
Index: trunk/extensions/FlaggedRevs/FlaggedArticle.php
@@ -125,7 +125,7 @@
126126 $tag = wfMsgExt( $msg, array('parseinline'), $frev->getRevId(), $time );
127127 # Hide clutter
128128 if( !FlaggedRevs::useSimpleUI() && !empty($flags) ) {
129 - $tag .= " <span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none; cursor:pointer;'" .
 129+ $tag .= " <span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none;'" .
130130 " onclick='toggleRevRatings()' title='" . wfMsgHtml('revreview-toggle-title') . "' >" .
131131 wfMsg( 'revreview-toggle' ) . "</span>";
132132 $tag .= "<span id='mw-revisionratings' style='display:block;'>" .
@@ -195,7 +195,7 @@
196196 wfMsgExt( $msg, array('parseinline'), $frev->getRevId(), $time );
197197 # Hide clutter
198198 if( !empty($flags) ) {
199 - $tag .= " <span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none; cursor:pointer;'" .
 199+ $tag .= " <span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none;'" .
200200 " onclick='toggleRevRatings()' title='" . wfMsgHtml('revreview-toggle-title') . "' >" .
201201 wfMsg( 'revreview-toggle' ) . "</span>";
202202 $tag .= "<span id='mw-revisionratings' style='display:block;'>" .
@@ -263,7 +263,7 @@
264264 $tag .= "<span class='{$css}' title=\"{$tooltip}\"></span>" . $msgHTML;
265265 # Hide clutter
266266 if( !empty($flags) ) {
267 - $tag .= " <span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none; cursor:pointer;'" .
 267+ $tag .= " <span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none;'" .
268268 " onclick='toggleRevRatings()' title='" . wfMsgHtml('revreview-toggle-title') . "' >" .
269269 wfMsg( 'revreview-toggle' ) . "</span>";
270270 $tag .= "<span id='mw-revisionratings' style='display:block;'>" .
@@ -311,7 +311,7 @@
312312 $tag = "<span class='{$css} plainlinks' title=\"{$tooltip}\"></span>" .
313313 wfMsgExt( $msg, array('parseinline'), $frev->getRevId(), $time, $revs_since );
314314 if( !empty($flags) ) {
315 - $tag .= " <span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none; cursor:pointer;'" .
 315+ $tag .= " <span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none;'" .
316316 " onclick='toggleRevRatings()' title='" . wfMsgHtml('revreview-toggle-title') . "' >" .
317317 wfMsg('revreview-toggle') . "</span>";
318318 $tag .= "<span id='mw-revisionratings' style='display:block;'>" .
@@ -446,7 +446,7 @@
447447 wfMsgExt( $msg, array('parseinline'), $frev->getRevId(), $time, $revs_since );
448448 # Hide clutter
449449 if( !empty($flags) ) {
450 - $tag .= " <span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none; cursor:pointer;'" .
 450+ $tag .= " <span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none;'" .
451451 " onclick='toggleRevRatings()' title='" . wfMsgHtml('revreview-toggle-title') . "' >" .
452452 wfMsg( 'revreview-toggle' ) . "</span>";
453453 $tag .= '<span id="mw-revisionratings" style="display:block;">' .
@@ -982,18 +982,20 @@
983983 $html = wfMsgExt($msg, array('parseinline'), $frev->getRevId(), $time, $revs_since );
984984 }
985985 # Make fancy box...
986 - $box = "<div>";
987 - $box .= "<span style='float: left;'>$shtml&nbsp;</span>";
988 - $box .= "<span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none; cursor:pointer; float: right;'
 986+ $box = "<table border='0' cellspacing='0' style='background: none;'>\n";
 987+ $box .= "<tr><td>$shtml&nbsp;</td><td align='right'>";
 988+ $box .= "<span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none;'
989989 onclick='toggleRevRatings()' title='" . wfMsgHtml('revreview-toggle-title') . "'>" .
990 - wfMsgHtml( 'revreview-toggle' ) . "</span></div>";
991 - $box .= '<div id="mw-revisionratings" style="clear: both;">';
 990+ wfMsgHtml( 'revreview-toggle' ) . "</span></td></tr>";
 991+ $box .= "<tr><td>";
 992+ $box .= "<span id='mw-revisionratings'>";
992993 $box .= $html;
993994 # Add ratings if there are any...
994995 if( $stable && !empty($flags) ) {
995996 $box .= $this->addTagRatings( $flags, true, $color );
996997 }
997 - $box .= '</div>';
 998+ $box .= "</span></tr></td>";
 999+ $box .= "</table>";
9981000
9991001 return $box;
10001002 }

Status & tagging log