r34403 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34402‎ | r34403 | r34404 >
Date:22:52, 7 May 2008
Author:aaron
Status:old
Tags:
Comment:
*Use default display (inline)
*Table tweaks
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticle.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/flaggedrevs.js (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedArticle.php
@@ -983,19 +983,17 @@
984984 }
985985 # Make fancy box...
986986 $box = "<table border='0' cellspacing='0' style='background: none;'>\n";
987 - $box .= "<tr><td>$shtml&nbsp;</td><td align='right'>";
 987+ $box .= "<tr><td>$shtml</td><td>&nbsp;</td><td align='right'>\n";
988988 $box .= "<span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none;'
989989 onclick='toggleRevRatings()' title='" . wfMsgHtml('revreview-toggle-title') . "'>" .
990 - wfMsgHtml( 'revreview-toggle' ) . "</span></td></tr>";
991 - $box .= "<tr><td>";
992 - $box .= "<span id='mw-revisionratings'>";
 990+ wfMsgHtml( 'revreview-toggle' ) . "</span></td></tr>\n";
 991+ $box .= "<tr><td id='mw-revisionratings'>\n";
993992 $box .= $html;
994993 # Add ratings if there are any...
995994 if( $stable && !empty($flags) ) {
996995 $box .= $this->addTagRatings( $flags, true, $color );
997996 }
998 - $box .= "</span></tr></td>";
999 - $box .= "</table>";
 997+ $box .= "</td></tr></table>";
1000998
1001999 return $box;
10021000 }
Index: trunk/extensions/FlaggedRevs/flaggedrevs.js
@@ -15,7 +15,7 @@
1616 var ratings = document.getElementById('mw-revisionratings');
1717 if( !ratings ) return;
1818 if( ratings.style.display == 'none' ) {
19 - ratings.style.display = 'block';
 19+ ratings.style.display = 'inline';
2020 } else {
2121 ratings.style.display = 'none';
2222 }

Status & tagging log