r30117 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r30116‎ | r30117 | r30118 >
Date:12:57, 24 January 2008
Author:raymond
Status:old (Comments)
Tags:
Comment:
* Sort elements by alphabet
* Consistent usage of XML functions
Modified paths:
  • /trunk/phase3/includes/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialVersion.php
@@ -193,7 +193,7 @@
194194 foreach ($myWgHooks as $hook => $hooks)
195195 $ret .= "<tr><td>$hook</td><td>" . $this->listToText( $hooks ) . "</td></tr>\n";
196196
197 - $ret .= '</table>';
 197+ $ret .= Xml::closeElement( 'table' );
198198 return $ret;
199199 } else
200200 return '';
@@ -232,6 +232,7 @@
233233 */
234234 function listToText( $list ) {
235235 $cnt = count( $list );
 236+ sort( $list );
236237
237238 if ( $cnt == 1 ) {
238239 // Enforce always returning a string

Follow-up revisions

RevisionCommit summaryAuthorDate
r62057Fix regression introduced in r30117: Don's sort() the author list in...avar01:50, 6 February 2010

Comments

#Comment by Ævar Arnfjörð Bjarmason (talk | contribs)   01:51, 6 February 2010

There was a bug in this commit, I fixed it in r62057.

Status & tagging log