r29798 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r29797‎ | r29798 | r29799 >
Date:15:53, 15 January 2008
Author:thomasv
Status:old
Tags:
Comment:
fix for IE
Modified paths:
  • /trunk/extensions/ProofreadPage/proofread_index.js (modified) (history)
  • /trunk/extensions/WebStore/404-handler.php (modified) (history)
  • /trunk/extensions/WebStore/WebStorePostFile.php (modified) (history)
  • /trunk/phase3/includes/MimeMagic.php (modified) (history)
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/MimeMagic.php
@@ -84,19 +84,19 @@
8585 * Mapping of media types to arrays of mime types.
8686 * This is used by findMediaType and getMediaType, respectively
8787 */
88 - var $mMediaTypes= NULL;
 88+ public static $mMediaTypes= NULL;
8989
9090 /** Map of mime type aliases
9191 */
92 - var $mMimeTypeAliases= NULL;
 92+ public static $mMimeTypeAliases= NULL;
9393
9494 /** map of mime types to file extensions (as a space seprarated list)
9595 */
96 - var $mMimeToExt= NULL;
 96+ public static $mMimeToExt= NULL;
9797
9898 /** map of file extensions types to mime types (as a space seprarated list)
9999 */
100 - var $mExtToMime= NULL;
 100+ public static $mExtToMime= NULL;
101101
102102 /** The singleton instance
103103 */
Index: trunk/phase3/includes/SkinTemplate.php
@@ -772,7 +772,7 @@
773773
774774 wfProfileOut( "$fname-live" );
775775
776 - if( $this->loggedin ) {
 776+ if( $this->loggedin && 0) {
777777 if( !$this->mTitle->userIsWatching()) {
778778 $content_actions['watch'] = array(
779779 'class' => ($action == 'watch' or $action == 'unwatch') ? 'selected' : false,
Index: trunk/extensions/WebStore/WebStorePostFile.php
@@ -1,7 +1,7 @@
22 <?php
33
44 class WebStorePostFile {
5 - var $curl, $content, $outputFile, $errno, $error, $responseCode, $contentType, $success,
 5+ public static $curl, $content, $outputFile, $errno, $error, $responseCode, $contentType, $success,
66 $sourceFile, $sourcePath;
77
88 static function post( $url, $fileParamName, $sourcePath, $params = array(), $proxy = false,
Index: trunk/extensions/WebStore/404-handler.php
@@ -30,8 +30,7 @@
3131 $this->real404();
3232 return true;
3333 }
34 -
35 - $rel = substr( $url, strlen( $thumbBase ) + 1 ); // plus one for slash
 34+ $rel = substr( $url, strlen( $thumbBase ) + 1 ); //plus one for slash
3635 // Check for path traversal
3736 if ( !$this->validateFilename( $rel ) ) {
3837 header( 'X-Debug: invalid path traversal' );
@@ -41,6 +40,7 @@
4241
4342 if ( !preg_match( '!^(\w)/(\w\w)/([^/]*)/([^/]*)$!', $rel, $parts ) ) {
4443 header( 'X-Debug: regex mismatch' );
 44+ print $rel;
4545 $this->real404();
4646 return false;
4747 }
Index: trunk/extensions/ProofreadPage/proofread_index.js
@@ -13,7 +13,7 @@
1414
1515 function proofreadpage_index_init() {
1616
17 - if(!self.proofreadpage_debug) return;
 17+ if(!self.proofreadpage_debug) return;
1818
1919 var toolbar = document.getElementById("toolbar");
2020 toolbar.parentNode.removeChild(toolbar);
@@ -86,6 +86,9 @@
8787 param_name = m[0];
8888
8989 value = form.elements[param_name].value;
 90+ //remove training \n
 91+ value = value.replace(/\n$/,'');
 92+ //replace pipe symbol
9093 value = value.replace(/\|/g,'{{!}}');
9194 //not for links!
9295 value = value.replace(/\[\[(.*?)\{\{!\}\}(.*?)\]\]/g,'[[$1|$2]]');

Follow-up revisions

RevisionCommit summaryAuthorDate
r29799Reverting r29798 on the committer's request, part 1 of 2catrope16:04, 15 January 2008
r29800Reverting r29798 on the committer's request, part 2 of 2catrope16:05, 15 January 2008

Status & tagging log