r29800 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r29799‎ | r29800 | r29801 >
Date:16:05, 15 January 2008
Author:catrope
Status:old
Tags:
Comment:
Reverting r29798 on the committer's request, part 2 of 2
Modified paths:
  • /trunk/extensions/ProofreadPage/proofread_index.js (modified) (history)
  • /trunk/extensions/WebStore/404-handler.php (modified) (history)
  • /trunk/extensions/WebStore/WebStorePostFile.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WebStore/WebStorePostFile.php
@@ -1,7 +1,7 @@
22 <?php
33
44 class WebStorePostFile {
5 - public static $curl, $content, $outputFile, $errno, $error, $responseCode, $contentType, $success,
 5+ var $curl, $content, $outputFile, $errno, $error, $responseCode, $contentType, $success,
66 $sourceFile, $sourcePath;
77
88 static function post( $url, $fileParamName, $sourcePath, $params = array(), $proxy = false,
Index: trunk/extensions/WebStore/404-handler.php
@@ -30,7 +30,8 @@
3131 $this->real404();
3232 return true;
3333 }
34 - $rel = substr( $url, strlen( $thumbBase ) + 1 ); //plus one for slash
 34+
 35+ $rel = substr( $url, strlen( $thumbBase ) + 1 ); // plus one for slash
3536 // Check for path traversal
3637 if ( !$this->validateFilename( $rel ) ) {
3738 header( 'X-Debug: invalid path traversal' );
@@ -40,7 +41,6 @@
4142
4243 if ( !preg_match( '!^(\w)/(\w\w)/([^/]*)/([^/]*)$!', $rel, $parts ) ) {
4344 header( 'X-Debug: regex mismatch' );
44 - print $rel;
4545 $this->real404();
4646 return false;
4747 }
Index: trunk/extensions/ProofreadPage/proofread_index.js
@@ -13,7 +13,7 @@
1414
1515 function proofreadpage_index_init() {
1616
17 - if(!self.proofreadpage_debug) return;
 17+ if(!self.proofreadpage_debug) return;
1818
1919 var toolbar = document.getElementById("toolbar");
2020 toolbar.parentNode.removeChild(toolbar);
@@ -86,9 +86,6 @@
8787 param_name = m[0];
8888
8989 value = form.elements[param_name].value;
90 - //remove training \n
91 - value = value.replace(/\n$/,'');
92 - //replace pipe symbol
9390 value = value.replace(/\|/g,'{{!}}');
9491 //not for links!
9592 value = value.replace(/\[\[(.*?)\{\{!\}\}(.*?)\]\]/g,'[[$1|$2]]');

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r29798fix for IEthomasv15:53, 15 January 2008

Status & tagging log