r28611 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r28610‎ | r28611 | r28612 >
Date:23:40, 17 December 2007
Author:werdna
Status:old
Tags:
Comment:
Revert r28576 (by me). Violates the RfC spec on email (mailbox local-part is case-sensitive according to RfC2821)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialPreferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialPreferences.php
@@ -306,7 +306,7 @@
307307 if( $wgEnableEmail ) {
308308 $newadr = $this->mUserEmail;
309309 $oldadr = $wgUser->getEmail();
310 - if( ($newadr != '') && (strtolower($newadr) != strtolower($oldadr)) ) {
 310+ if( ($newadr != '') && ($newadr != $oldadr) ) {
311311 # the user has supplied a new email address on the login page
312312 if( $wgUser->isValidEmailAddr( $newadr ) ) {
313313 $wgUser->mEmail = $newadr; # new behaviour: set this new emailaddr from login-page into user database record
Index: trunk/phase3/RELEASE-NOTES
@@ -248,8 +248,6 @@
249249 user-customized ones (like Common.css, Common.js)
250250 * (bug 12283) Special:Newpages forgets parameters
251251 * (bug 12031) All namespaces doesn't work in Special:Newpages
252 -* Email addresses are now not considered case-sensitive in detecting if
253 - a user has changed their email address.
254252
255253 == Parser changes in 1.12 ==
256254

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r28576* Ignore case in checking for a changed email address in Special:Preferences....werdna03:01, 17 December 2007

Status & tagging log