r28612 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r28611‎ | r28612 | r28613 >
Date:23:44, 17 December 2007
Author:raymond
Status:old
Tags:
Comment:
* Rename new message 'filetype-separator' (r28530) to the more generic message name 'comma-separator'.
Can be useful for other still hardcoded comma separations.
Modified paths:
  • /trunk/phase3/includes/SpecialUpload.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesAr.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messageTypes.inc (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -2203,7 +2203,7 @@
22042204 'separators' => array(
22052205 'catseparator',
22062206 'semicolon-separator',
2207 - 'filetype-separator',
 2207+ 'comma-separator',
22082208 ),
22092209 'imgmulti' => array(
22102210 'imgmultipageprev',
Index: trunk/phase3/maintenance/language/messageTypes.inc
@@ -265,7 +265,7 @@
266266 'hebrew-calendar-m11-gen',
267267 'hebrew-calendar-m12-gen',
268268 'semicolon-separator',
269 - 'filetype-separator',
 269+ 'comma-separator',
270270 );
271271
272272 /** EXIF messages, which may be set as optional in several checks, but are generally mandatory */
Index: trunk/phase3/includes/SpecialUpload.php
@@ -326,7 +326,7 @@
327327 array( 'parseinline' ),
328328 htmlspecialchars( $finalExt ),
329329 implode(
330 - wfMsgExt( 'filetype-separator', array( 'escapenoentities' ) ),
 330+ wfMsgExt( 'comma-separator', array( 'escapenoentities' ) ),
331331 $wgFileExtensions
332332 )
333333 )
@@ -508,7 +508,7 @@
509509 array( 'parseinline' ),
510510 htmlspecialchars( $finalExt ),
511511 implode(
512 - wfMsgExt( 'filetype-separator', array( 'escapenoentities' ) ),
 512+ wfMsgExt( 'comma-separator', array( 'escapenoentities' ) ),
513513 $wgFileExtensions
514514 )
515515 ) . '</li>';
@@ -970,7 +970,7 @@
971971 global $wgCheckFileExtensions, $wgStrictFileExtensions,
972972 $wgFileExtensions, $wgFileBlacklist;
973973 if( $wgCheckFileExtensions ) {
974 - $delim = wfMsgExt( 'filetype-separator', array( 'escapenoentities' ) );
 974+ $delim = wfMsgExt( 'comma-separator', array( 'escapenoentities' ) );
975975 if( $wgStrictFileExtensions ) {
976976 # Everything not permitted is banned
977977 $wgOut->addHTML(
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2970,7 +2970,7 @@
29712971 # Separators for various lists
29722972 'catseparator' => '|', # don't translate or duplicate this message to other languages
29732973 'semicolon-separator' => ';', # only translate this message to other languages if you have to change it
2974 -'filetype-separator' => ', ', # only translate this message to other languages if you have to change it
 2974+'comma-separator' => ', ', # only translate this message to other languages if you have to change it
29752975
29762976 # Multipage image navigation
29772977 'imgmultipageprev' => '← previous page',
Index: trunk/phase3/languages/messages/MessagesAr.php
@@ -2522,7 +2522,7 @@
25232523
25242524 # Separators for various lists
25252525 'semicolon-separator' => '؛',
2526 -'filetype-separator' => '،',
 2526+'comma-separator' => '،',
25272527
25282528 # Multipage image navigation
25292529 'imgmultipageprev' => '← الصفحة السابقة',
Index: trunk/phase3/languages/messages/MessagesEl.php
@@ -2359,9 +2359,6 @@
23602360 'articletitles' => "Άρθρα που αρχίζουν από ''$1''",
23612361 'hideresults' => 'Απόκρυψη αποτελεσμάτων',
23622362
2363 -# Separators for various lists
2364 -'filetype-separator' => ',',
2365 -
23662363 # Multipage image navigation
23672364 'imgmultipageprev' => '← προηγούμενη σελίδα',
23682365 'imgmultipagenext' => 'επόμενη σελίδα →',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r28530* Special:Upload now lists permitted/prohibited file extensions....simetrical00:06, 16 December 2007

Status & tagging log