r25822 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25821‎ | r25822 | r25823 >
Date:08:31, 13 September 2007
Author:raymond
Status:old
Tags:
Comment:
* (bug 11321) Fix width of gallerybox when option "width=xxx" is used
See the screenshots before/after attached to the bug.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ImageGallery.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImageGallery.php
@@ -303,7 +303,7 @@
304304 $s .= "\n\t<tr>";
305305 }
306306 $s .=
307 - "\n\t\t" . '<td><div class="gallerybox" style="width: '.($this->mWidths*1.25).'px;">'
 307+ "\n\t\t" . '<td><div class="gallerybox" style="width: '.($this->mWidths+35).'px;">'
308308 . $thumbhtml
309309 . "\n\t\t\t" . '<div class="gallerytext">' . "\n"
310310 . $textlink . $text . $nb
Index: trunk/phase3/RELEASE-NOTES
@@ -49,8 +49,8 @@
5050 * (bug 9252) Fix for tidy funkiness when using editintro mode
5151 * (bug 4021) Fix for MySQL wildcard search
5252 * (bug 10699) Fix for MySQL phrase search
 53+* (bug 11321) Fix width of gallerybox when option "width=xxx" is used
5354
54 -
5555 === API changes in 1.12 ===
5656
5757 Full API documentation is available at http://www.mediawiki.org/wiki/API

Follow-up revisions

RevisionCommit summaryAuthorDate
r25833adjust parser tests to match slightly wider gallery width per r25822brion19:24, 13 September 2007
r25849Merged revisions 25804-25848 via svnmerge from...david06:54, 14 September 2007

Status & tagging log