r25796 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25795‎ | r25796 | r25797 >
Date:19:41, 11 September 2007
Author:catrope
Status:old
Tags:
Comment:
Fixing very stupid typo in Special:Userrights, which allowed all sysops to add and remove everyone to and from every group.
Modified paths:
  • /trunk/phase3/includes/SpecialUserrights.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialUserrights.php
@@ -326,7 +326,7 @@
327327
328328 foreach ($addergroups as $addergroup) {
329329 $groups = array_merge_recursive(
330 - $groups, $this->changeableByGroup($addergroup)
 330+ $groups, $this->changeableByGroup($addergroups)
331331 );
332332 $groups['add'] = array_unique( $groups['add'] );
333333 $groups['remove'] = array_unique( $groups['remove'] );
@@ -399,4 +399,4 @@
400400 $viewer->showList( $output );
401401 }
402402
403 -}
\ No newline at end of file
 403+}

Follow-up revisions

RevisionCommit summaryAuthorDate
r25797Reverting stupidity from r25796, apologizing for own accusations of stupidity.catrope19:50, 11 September 2007
r25804Merged revisions 25752-25803 via svnmerge from...david02:25, 12 September 2007
r25835apiedit: Merging r25796 and beyond from trunkcatrope20:00, 13 September 2007

Status & tagging log